984934 - Make it impossible to have nameless Collections in the API

Status: RESOLVED FIXED

(Marketplace Graveyard :: API, defect, P3)

Description

[Chuck Harmston [:chuck]]

This collection appears to have been created without a name:

https://marketplace-dev.allizom.org/curation/collection/robs-test-collection
https://marketplace-dev.allizom.org/api/v1/rocketfuel/collections/robs-test-collection

This shouldn't be possible; it appears that validation on API responses is failing somewhere.

Comment 1

[Mathieu Pillard [:mat]]

I'm guessing we just had an error when saving the translation - since it has a slug, it probably had a valid name submitted, but some db error prevented the translation to be saved.

Comment 2

[Mathieu Pillard [:mat]]

I still think my theory is valid, but I checked by disabling all safeguards in rocketfuel client and I was able to change the name back to an empty string, so definitely something missing in the API code.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

(In reply to Mathieu Pillard [:mat] from comment #2)
> I still think my theory is valid, but I checked by disabling all safeguards
> in rocketfuel client and I was able to change the name back to an empty
> string, so definitely something missing in the API code.

Is there an API bug filed for this?

Comment 4

[Mathieu Pillard [:mat]]

This very bug :)

Comment 5

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/pull/1903