984962 - Need for an easy app update url and channel switching from Developper menu in settings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[:gerard-majax]

To ease some work, being able to switch those URLs more easily would be awesome. Something like an Advanced Developper menu in Settings, hidden behind a pref or a magic trick would do the job.

Comment 1

[Gregor Wagner [:gwagner]]

Dogfood users might have to go there and change the channel. We should get some nice UX for this.

Comment 2

[Stephany Wilkes]

Flagging Omega for input on Settings.

Comment 3

[Omega Feng [:Omega] [:馮於懋]]

Not quite understand the request, so here are some questions:

1. Are we putting something in "Settings > Developer"?
2. How many fields do we need?
3. Are these fields single line text input? Or a value selector with some predefined options?

Comment 4

[:gerard-majax]

(In reply to Omega Feng [:Omega] from comment #3)
> Not quite understand the request, so here are some questions:
> 
> 1. Are we putting something in "Settings > Developer"?

That would be the idea.

> 2. How many fields do we need?

For now, I only see modification of app.update.channel and app.update.url.

> 3. Are these fields single line text input? Or a value selector with some
> predefined options?

I would prefer single input.

Comment 5

[Omega Feng [:Omega] [:馮於懋]]

See Bug 995124 for the Developer UX spec update.

Comment 7

[Jan Keromnes [:janx]]

Attachment: github pull request

Works but needs tests.

Comment 8

[Jan Keromnes [:janx]]

Comment on attachment 8405399 [details] [review]
github pull request

Actually I'm not sure if/how to test this. Do unit tests make sense here? How can I also cover the gecko part of this feature in bug #995206?

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8405399 [details] [review]
github pull request

Comment on github.

Comment 10

[Jan Keromnes [:janx]]

Comment on attachment 8405399 [details] [review]
github pull request

Second try, please have a look.

(Also, please feel free to r- my patches when you want them changed prior to landing. I don't mind, and bugzilla doesn't count resetting the `review` flag as an actual review.)

Comment 11

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8405399 [details] [review]
github pull request

Just make sure that the new pref name does not break updates, but since this pref is read-only it should be fine.

Comment 12

[Omega Feng [:Omega] [:馮於懋]]

See bug 995124 for the updated UX spec.