984976 - Australis - toolbar button type="menu-button" border behaviour is weird on Windows 8

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Tim Nguyen :ntim]

STR :
- Find a toolbar button of type="menu-button" (bookmarks widget, colorzilla,...)
- Click the dropmarker icon
- The border is normal

Issue 1 
-------------------
- Mouse out from that button or from it's menupopup
- See that the split border is missing
- Screenshot : http://images.devs-on.net/Image/u74pkHPLhJ4wrQWx-Region.png

Issue 2
-------------------
- In that menu-button, hover the button that isn't the dropmarker
- See there's a 2px separator
- Screenshot : http://images.devs-on.net/Image/sxzNENpWbd0yt6GJ-Region.png

Comment 1

[Justin Dolske [:Dolske]]

I don't have Win8 handy, but this seems like it's likely  to make the button feel wonky. Similar issues on OS X certainly did.

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I can reproduce

Comment 3

[:Gijs (he/him)]

Mike, can you address bug 981908 in the same patch? Seems like it's the same or a very similar problem...

Comment 4

[Mike de Boer [:mikedeboer]]

(In reply to :Gijs Kruitbosch from comment #3)
> Mike, can you address bug 981908 in the same patch? Seems like it's the same
> or a very similar problem...

I'll try, but it's not a very similar problem. If it manifests for type=menu-button buttons then I'll just go ahead and do it, but we both know that the UI elements for Bookmarks are different beasts, usually :-S

Comment 5

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: fix menu-button border states on Windows 8

Comment 6

[Mike de Boer [:mikedeboer]]

This patch also fixes bug bug 981908.

Comment 7

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/0909197d66d9

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0909197d66d9

Comment 10

[:Gijs (he/him)]

Comment on attachment 8394202 [details] [diff] [review]
Patch v1: fix menu-button border states on Windows 8

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis
User impact if declined: Menu-button type buttons shift on Windows 8
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): low, CSS-only fix
String or IDL/UUID changes made by this patch: none

Comment 12

[:Gijs (he/him)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7d8d9656a2c0
https://hg.mozilla.org/releases/mozilla-beta/rev/2d4875e8bb5e

Comment 13

[Cornel Ionce [:noni] [Hubs QA]]

Verified this as fixed using the STR from the description on Windows 8 32bit and 64bit architectures using:
- latest Aurora (build ID: 20140324150430)
- latest Nightly (build ID: 20140324030203)
- Firefox 29 beta 2 (build ID: 20140324101726)