Closed
Bug 984999
Opened 11 years ago
Closed 11 years ago
Move set_assign_to() out of bug/create/create.html.tmpl
Categories
(Bugzilla :: Creating/Changing Bugs, enhancement)
Bugzilla
Creating/Changing Bugs
Tracking
()
RESOLVED
FIXED
Bugzilla 5.0
People
(Reporter: LpSolit, Assigned: bePolite)
Details
Attachments
(1 file, 2 obsolete files)
7.73 KB,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
The set_assign_to() JS function should go out of the bug/create/create.html.tmpl template and be moved into js/bug.js. Param("useqacontact") can be passed as argument.
Assignee | ||
Comment 1•11 years ago
|
||
This patch moves set_assign_to() JS function out of bug/create/create.html.tmpl into js/bug.js. Param("useqacontact") is passed as an
Attachment #8395154 -
Flags: review?(gerv)
Assignee | ||
Comment 2•11 years ago
|
||
This update of the previous patch uses a meaningful variable name in /bug/create/create.html.templ
Attachment #8395154 -
Attachment is obsolete: true
Attachment #8395154 -
Flags: review?(gerv)
Attachment #8395164 -
Flags: review?(gerv)
![]() |
Reporter | |
Comment 3•11 years ago
|
||
Comment on attachment 8395164 [details] [diff] [review]
Update for previous patch
>+function set_assign_to(useqacontact) {
useqacontact -> use_qa_contact
>+[% local_useqacontact = Param("useqacontact") %]
local_useqacontact -> use_qa_contact
Otherwise looks good.
Attachment #8395164 -
Flags: review?(gerv) → review-
Assignee | ||
Comment 4•11 years ago
|
||
>useqacontact -> use_qa_contact
I have changed the useqacontact parameter to use_qa_contact
>local_useqacontact -> use_qa_contact
I also changed the local_use_qa_contact variable to use_qa_contact
Attachment #8395164 -
Attachment is obsolete: true
Attachment #8395240 -
Flags: review?
![]() |
Reporter | |
Comment 5•11 years ago
|
||
Comment on attachment 8395240 [details] [diff] [review]
Update for previous patch due to comment 3
>diff --git a/js/bug.js b/js/bug.js
>+function set_assign_to(use_qa_contactu) {
contactu -> contact
>+ if (use_qa_contact){
Nit: add a whitespace before {.
>+ if (use_qa_contact){
Same here.
r=LpSolit with these fixes on checkin.
Attachment #8395240 -
Flags: review? → review+
![]() |
Reporter | |
Updated•11 years ago
|
Assignee: general → acho.arnold
Status: NEW → ASSIGNED
Component: Bugzilla-General → Creating/Changing Bugs
Flags: approval?
Whiteboard: [Good Intro Bug]
Target Milestone: --- → Bugzilla 5.0
Updated•11 years ago
|
Flags: approval? → approval+
![]() |
Reporter | |
Comment 6•11 years ago
|
||
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
165689a..bd12f03 master -> master
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•11 years ago
|
||
> r=LpSolit with these fixes on checkin.
Thanks for the fixes. It seems I did the typo after testing
removed tabs from js/bug.js:
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
bd12f03..fd518e1 master -> master
You need to log in
before you can comment on or make changes to this bug.
Description
•