Allow stats for apps with public_stats=True

VERIFIED FIXED in 2014-09-16

Status

Marketplace
Statistics
P2
normal
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: Daniele "Mte90" Scasciafratte, Assigned: spasovski)

Tracking

Avenir
2014-09-16
Points:
---

Details

(Whiteboard: [incorrect_implementation])

(Reporter)

Description

3 years ago
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0 Iceweasel/29.0a2 (Beta/Release)
Build ID: 20140214004003

Steps to reproduce:

Login to marketplace
Go to the page of statistics of my app (now are public) https://marketplace.firefox.com/statistics/app/ringtone-picker
See the statistics


Actual results:

Authentication error you are trying to read not public data


Expected results:

See the statistics.


It's very annoying this problem...
(Assignee)

Updated

3 years ago
Assignee: nobody → dspasovski
Component: General → Statistics
Priority: -- → P2
Currently stats are only visible to app owners (or users with a certain permission to view stats -- admins).

I'm updating the title of this bug to reflect that we should be allowing stats views to apps who have set the public stats flag.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Authentication error on Statistics of the app → Allow stats for apps with public_stats=True
(Reporter)

Comment 2

3 years ago
Ehm yes this title it's better.

The problem exist also with the privated stats, i have tried with the public for see if there is a problem only of private.

I have other developer that have the same problem with the statistics.
(Assignee)

Updated

3 years ago
Assignee: dspasovski → nobody

Updated

3 years ago
Whiteboard: [incorrect_implementation]
(Reporter)

Comment 3

3 years ago
Now the stats work with the public and private option.
(Reporter)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → INVALID
After some testing today this is still a problem. Reopening.

If a developer sets their app as public_stats=True the stats are not visible to anonymous users or non-owners as they should be.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

Comment 5

3 years ago
(In reply to Rob Hudson [:robhudson] from comment #4)
> After some testing today this is still a problem. Reopening.
> 
> If a developer sets their app as public_stats=True the stats are not visible
> to anonymous users or non-owners as they should be.

Related to this? https://bugzilla.mozilla.org/show_bug.cgi?id=1066119
https://github.com/mozilla/zamboni/commit/44768c3 

To verify:
Set an app's public_stats to True.
Verify that an anonymous user and a non-owner can view the stats.
Assignee: nobody → robhudson.mozbugs
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2014-09-16

Comment 7

3 years ago
Anonymous users are not able to access the public stats and authentication is prompted.
Please see screencast  http://screencast.com/t/El9OctTU9kr
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to Iulian Timis from comment #7)
> Anonymous users are not able to access the public stats and authentication
> is prompted.
> Please see screencast  http://screencast.com/t/El9OctTU9kr

Thanks.

Passing to Davor to remove the login prompt if stats are public.
Assignee: robhudson.mozbugs → dspasovski
https://github.com/mozilla/zamboni/commit/f641f0e for backend. Davor has a front-end commit incoming.
(Assignee)

Comment 10

3 years ago
https://github.com/mozilla/marketplace-stats/pull/44
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED

Comment 11

3 years ago
(In reply to Davor Spasovski [:spasovski] from comment #10)
> https://github.com/mozilla/marketplace-stats/pull/44

Anonymous users are still not able to access the public stats and authentication is prompted.
Please see screencast http://screencast.com/t/Gb9oxCltuDb
(Assignee)

Comment 12

3 years ago
Hi Rabimba thanks for the help in diagnosing this issue we wouldn't have caught it without your help. You won't see the fix in production (marketplace.firefox.com) until Tuesday at the earliest or possibly a week from that if any issues with the solution are found by QA.

We test in multiple stages before code pushes go out but feel free to ask again on Wednesday if the issue seems to persist.

Comment 13

3 years ago
(In reply to Davor Spasovski [:spasovski] from comment #12)
> Hi Rabimba thanks for the help in diagnosing this issue we wouldn't have
> caught it without your help. You won't see the fix in production
> (marketplace.firefox.com) until Tuesday at the earliest or possibly a week
> from that if any issues with the solution are found by QA.
> 
> We test in multiple stages before code pushes go out but feel free to ask
> again on Wednesday if the issue seems to persist.

Happy to help. Will test it after Wednesday in that case.
Also if there is a Automated QA in place I will be happy to help/volunteer/contribute.

Comment 14

3 years ago
Verified as fixed inhttps://marketplace-dev.allizom.org/ on FF35 (Win 7).
Postfix screencast http://screencast.com/t/cYl2dEMdc
Closing bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.