Closed
Bug 985058
Opened 10 years ago
Closed 10 years ago
[Camera] [Mozilla][UX] 1.4 Viewfinder Assets not to spec
Categories
(Firefox OS Graveyard :: Gaia::Camera, defect, P1)
Tracking
(b2g-v1.4 fixed, b2g-v2.0 fixed)
RESOLVED
FIXED
1.4 S5 (11apr)
People
(Reporter: amylee, Assigned: wilsonpage)
References
Details
(Whiteboard: ux-tracking, visual design, jian [fxos:media])
Attachments
(4 files)
Hi I've reviewed the viewfinder and have attached my edits. Let me know if you have any questions.
Comment 2•10 years ago
|
||
What about the distance betweeen the gallery and the capture buttons? Still 18px?
Flags: needinfo?(amlee)
Reporter | ||
Comment 3•10 years ago
|
||
Hi Diego, The specs are optimized for the Madai camera which is 720px wide (See attached). If I increase the spacing between the camera shutter and the other 2 buttons, the buttons will be too close to the edges of the screen. Please keep the buttons at 18px distance between each other. Thanks.
Flags: needinfo?(amlee)
Comment 4•10 years ago
|
||
What about going for a more fluid design? What about aligning the mode switch and the gallery buttons to the front/back rear camera and settings buttons at the top? This would create horizontal balance in the controls since the buttons will make use of the available space and would create symmetry with respect to the buttons at the top.
Flags: needinfo?(amlee)
Reporter | ||
Comment 5•10 years ago
|
||
(In reply to Diego Marcos [:dmarcos] from comment #4) > What about going for a more fluid design? What about aligning the mode > switch and the gallery buttons to the front/back rear camera and settings > buttons at the top? This would create horizontal balance in the controls > since the buttons will make use of the available space and would create > symmetry with respect to the buttons at the top. Hi Diego, This was initially considered but the aim is to have the controls together as a unit. Depending on how wide the screen is, the controls may be too wide apart and we lose the feeling of them belonging as one cluster. I want to keep the controls as is for now (with the addition of the edits I've posted) and review them on the actual devices we are shipping the OS on. Thanks!
Flags: needinfo?(amlee)
Updated•10 years ago
|
Summary: [Camera] [Mozilla] 1.4 Viewfinder Assets not to spec → [Camera] [Mozilla][UX] 1.4 Viewfinder Assets not to spec
Reporter | ||
Comment 6•10 years ago
|
||
There is currently a fade in highlight state when you press on the settings menu button. It should highlight blue right away without a fade in. Can you please change to 0 (see line 1192 in attachment). Thanks!
Assignee | ||
Comment 7•10 years ago
|
||
amlee: This bug is about viewfinder. Your last comment relates to settings menu or HUD
Flags: needinfo?(amlee)
Assignee | ||
Comment 8•10 years ago
|
||
amlee: I have implemented the change as part of bug 972137
Flags: needinfo?(amlee)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → wilsonpage
Assignee | ||
Comment 9•10 years ago
|
||
Attachment #8395759 -
Flags: ui-review?(amlee)
Assignee | ||
Updated•10 years ago
|
Attachment #8395759 -
Flags: review?(dmarcos)
Reporter | ||
Updated•10 years ago
|
Attachment #8395759 -
Flags: ui-review?(amlee) → ui-review+
Updated•10 years ago
|
Attachment #8395759 -
Flags: review?(dmarcos) → review+
Comment 10•10 years ago
|
||
Landed in camera new features: https://github.com/mozilla-b2g/gaia/commit/6f04435499ea00f6b0f653863560e7cdf845423d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 11•10 years ago
|
||
Comment on attachment 8395759 [details] [review] pull-request (camera-new-features) Sorry, the toggle switch is still 8 rem by 4 rem. it should be 7.6 rem by 3.8 rem
Attachment #8395759 -
Flags: ui-review+ → ui-review-
Reporter | ||
Updated•10 years ago
|
Attachment #8395759 -
Flags: ui-review?(tshakespeare)
Comment 12•10 years ago
|
||
Amy to confirm if this is still an issue or if it has been resolved since her last update was a review -.
Flags: needinfo?(amlee)
Comment 13•10 years ago
|
||
Bulk edit for camera bugs. If earlier comments do not show how this bug landed to master, it probably landed as part of https://github.com/mozilla-b2g/gaia/pull/17599 which merged the camera-new-features branch into master. This bug was uplifted from master to v1.4 as part of https://github.com/mozilla-b2g/gaia/commit/a8190d08e61316a86bba572ba8d894d081a20530
Reporter | ||
Comment 14•10 years ago
|
||
(In reply to Tiffanie Shakespeare from comment #12) > Amy to confirm if this is still an issue or if it has been resolved since > her last update was a review -. I loaded the patch https://github.com/mozilla-b2g/gaia/pull/17599 and the toggle switch is still 8 rem by 4 rem. it should be 7.6 rem by 3.8 rem.
Flags: needinfo?(amlee) → needinfo?(wilsonpage)
You need to log in
before you can comment on or make changes to this bug.
Description
•