Closed
Bug 985085
Opened 12 years ago
Closed 12 years ago
Interpreter: Dead code in FunctionToString
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
INVALID
People
(Reporter: bbouvier, Assigned: bbouvier)
Details
Attachments
(1 file)
|
1.38 KB,
patch
|
Details | Diff | Splinter Review |
bool haveSource = fun->isInterpreted() && !fun->isSelfHostedBuiltin();
if (haveSource) {
... // big amount of code
} else if (fun->isInterpreted() && !fun->isSelfHostedBuiltin()) {
// dead code
} ...
It's pretty reassuring that we can't actually have sourceless code.
Jorendorff, I see you are one of the persons who touched around this code recently, so asking you for review (till is on PTO these days).
Attachment #8393058 -
Flags: review?(jorendorff)
|
Assignee | |
Comment 1•12 years ago
|
||
Actually if haveSource is true in the first place but loadSource sets it to false (for instance, if the runtime has no sourceHook), haveSource and (fun->isInterpreted() && !fun->isSelfHostedBuiltin()) will have different values, so that's invalid and will show "[native code]" instead of "[sourceless]". Sorry for the noise.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → INVALID
|
|
Assignee | |
Updated•12 years ago
|
Attachment #8393058 -
Flags: review?(jorendorff)
You need to log in
before you can comment on or make changes to this bug.
Description
•