Closed Bug 985260 Opened 11 years ago Closed 11 years ago

Add multiple multi-line highlights

Categories

(Webtools Graveyard :: DXR, defect)

Product:
Webtools Graveyard
Component:
DXR
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jamon, Assigned: jamon)

Details

Users are asking for the ability to select multiple blocks of discontinuous code. This functionality should match that found on MXR, for example: http://mxr.mozilla.org/mozilla-central/source/docshell/base/nsDocShell.h?rev=492ce94e6528&mark=94,96,98,100-113,120-134#90
A tweak: I don't think we need to support a scroll-to URL fragment separate from the topmost highlight region. (We already stow the highlight in the fragment, so it would be backward-breaking to step back from that.) Nobody's given me a use case for that yet, and at least one has said "Yeah, I don't know what that's for."
Done in https://github.com/mozilla/dxr/commit/f97e7f9ccdd63f3966340e098020fee6d13ad34a.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.