985299 - WebappsUpdateTimer component still registered when Synthetic APKs disabled

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P3)

Description

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: registers webapps update timer only if Synthetic APKs enabled

When Synthetic APKs are disabled, the WebappsUpdateTimer component is still registered with the category manager, which means the update timer manager will still try to notify the component that it's time to check for updates.

That shouldn't matter, because the attempt will throw an exception that the manager catches and ignores (or logs, if logging is enabled for that component).  But we should still button this up.

Here's a patch that does that.  Unlike bug 985184 and bug 985195, there's no need to uplift this, as Synthetic APKs are enabled on Aurora and Beta; and even if we were to disable them, the worst that will happen is that an exception will be caught and either completely ignored or logged.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8393331 [details] [diff] [review]
patch v1: registers webapps update timer only if Synthetic APKs enabled

Ugh, I should have caught this in my review.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a3cf7c3db77

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4a3cf7c3db77