985311 - [DSDS][Fugu] Tapping voicemail notification for SIM2 and it calls out from default SIM set in Sim manager

Status: RESOLVED DUPLICATE of bug 992129

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Eric Chang [:ericcc] [:echang]]

v1.5 on Fugu
GAIA_REV=2346ad9002062d70b6b27978c6b942f04192bf1b
GECKO_REV=93246f13841850c267bbb15915bffa7c2fcdac46
GAIA_BRANCH=mozillaorg/master
GECKO_BRANCH=mozillaorg/master
BUILD_TAG=jenkins-B2G.master.fugu-33
BuildID=20140319053035

1. Leave a voicemail for SIM2.
2. Default Outgoing calls in Sim Manager set to SIM1.
3. Tap on notification and it brings to dialing screen automatically.
4. <ISSUE> Call via SIM1
5. Default Outgoing calls in Sim Manager set to SIM2.
6. Tap on notification and it brings to dialing screen automatically.
7. <ISSUE> Call via SIM2.
http://youtu.be/_mhW7qPsEJA

Comment 1

[Eric Chang [:ericcc] [:echang]]

v1.4 on Fugu - Same issue
GAIA_REV=d2651c13d6370d62bf833b31c7e2e5f054510136
GECKO_REV=c8a17e25111585c0eebb829f8208190ea432c71e
GAIA_BRANCH=mozillaorg/master
GECKO_BRANCH=mozillaorg/master
BUILD_TAG=jenkins-B2G.master.fugu-32
BuildID=20140318053055

Comment 2

[Eric Chang [:ericcc] [:echang]]

Attachment: VMNumSetVMReceivedSIM2Dial

v1.4                                           
Gaia      7d716de0c186416b5b123baa1f3242e23d50529b
Gecko     47333352bbb537a81255370c1d7c2d9096e3c733
BuildID   20140328041552                  
Version   30.0a2                          

Currently I am not able to reproduce this using latest v1.4
but there is another bug which is already filed, and reproduced.

1. VM number set in Call settings for both SIMs
2. VM received for SIM2
3. VM number correct in notification
4. <ISSUE> Tap on notification and dial from SIM 1<default>!! 
https://bugzilla.mozilla.org/show_bug.cgi?id=985311

SIM1 VM - 123
SIM2 VM - 222

But SIM1 [0] is calling out 222 here, it should be SIM 2 [1] who tries to call.

line: 684
I/Gecko   (  107): TelephonyProvider: Dialing 222
I/Gecko   (  107): RIL Worker: [0] Received chrome message {"number":"222","isDialEmergency":false,"rilMessageClientId":0,"rilMessageToken":49,"rilMessageType":"dial"}

Comment 3

[Eric Chang [:ericcc] [:echang]]

Attachment: Test with combination - default SIM and VM set or not

Comment 4

[Eric Chang [:ericcc] [:echang]]

Testing again with SIM(with vm number in it, and fxos picks it up and puts that in call settings)
Same result as the matrix above.

Comment 5

[Preeti Raghunath(:Preeti)]

1.4+ for broken new feature

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

This is probably equal parts system and dialer, but taking for now.

Comment 7

[Candice Serran (:cserran)]

(In reply to Michael Henretty [:mhenretty] from comment #6)
> This is probably equal parts system and dialer, but taking for now.

Hi Michael,  if you're taking this, can you please assign to yourself? Thanks!

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Candice Serran (:cserran) from comment #7)
> Hi Michael,  if you're taking this, can you please assign to yourself?
> Thanks!

I'm not sure yet who from our team will work on this yet. Probably either Alexander or myself, but in any case, we will assign soon.

Comment 9

[:gerard-majax]

I suspect my patch for bug 992129 may solve this: I'm changing the telephony.dial() call to use the serviceId, i.e., asking it to place the call on the correct SIM card.

Eric, can you do a quick hack just changing the telephony.dial() call on your side to match bug 992129 ? If it fixes, then we should mark this bug as a dupe of bug 992129.

Comment 10

[Eric Chang [:ericcc] [:echang]]

Hi Alexandre,
v1.4 reproduce this bug, and it gets fixed after I applied that patch in bug 992129, thanks.
Gaia      184fc793c1c767ce2ce85f9ac3bd8835364ee49a   
Gecko     ce70d0ded922768db06e395a623bc436bf4d0114   
BuildID   20140411041552       
Version   30.0a2    
ro.build.version.incremental=eng.enpei.20140226.104  
420 
v1.5 works fine.