985317 - [Keyboard UX update][User Story] Visual hints on period key when long press available

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Bruce Huang [:bhuang] (inactive)]

As a user, I want to see visual hints on the period key so that is more immediately visible that additional functionality are available on long press.

Acceptance:
Visual “...” hint on the period key when in standard abc view.
Long press brings up a secondary menu.
No visual hint on period key when in symbol view

Refer to p.6 of UX spec in bug 983043

Comment 1

[Omega Feng [:Omega] [:馮於懋]]

See bug 983043 for the UX spec update.

Comment 2

[William Hsu [:whsu]]

Add the test cases.
- https://moztrap.mozilla.org/manage/cases/?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-tag=2571

Comment 3

[William Hsu [:whsu]]

Please skip the previous link. (Wrong link)
The correct one.
- https://moztrap.mozilla.org/manage/cases/?&pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-tag=2625

Comment 4

[Carol Huang [:Carol]]

See Bug 983043 for Visual spec, thanks

Comment 6

[Omega Feng [:Omega] [:馮於懋]]

Attachment: Visual hints on period key when long press

Comment 7

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8419967 [details] [review]
Visual hints on period key when long press

Looks good to me for showing the hint on the default layout.
However, according to acceptance criteria, we should not show it on symbol layout, because it may not have alternative chars defined for symbol panel.

Omega,

Great work, but could you please help take a look at the above requirement?
Thank you.

Comment 8

[Omega Feng [:Omega] [:馮於懋]]

Attachment: Visual hints on period key when long press

Hi Rudy,
Thanks for your feedback. I've just modified it. Now the period key shows the "..." only if it has alternatives.

Comment 9

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8420784 [details] [review]
Visual hints on period key when long press

Omega,

Thanks for the work.
Just commented on the pull request about the linter errors about coding styles, and we got some parts to be refined so that it would be concise for better readability.

Please help set the review flag back to me again when you update the patch.

Comment 10

[Omega Feng [:Omega] [:馮於懋]]

Attachment: Visual hints on period key when long press available.

Hi Rudy,
I've just modified the code based on your feedback. Please have a review again. Thanks a lot!

Comment 11

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8421523 [details] [review]
Visual hints on period key when long press available.

Hi Omega,

Thanks for the update.
I think we could reduce the duplicate code once again, please help take a look at my comment on the pull request.

Great work, it's almost done!

--
Please ask for review again, so I will be notified.
(You don't have to create attachment on bugzilla each time when you refresh your pull request, but it is up to you.)

Comment 12

[Omega Feng [:Omega] [:馮於懋]]

Comment on attachment 8421523 [details] [review]
Visual hints on period key when long press available.

Thanks Rudy! Here is the update.

Comment 13

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8421523 [details] [review]
Visual hints on period key when long press available.

Looks pretty good.
Please help take a look at a final nit about the indent,
https://github.com/mozilla-b2g/gaia/pull/19095#discussion_r12572640
and I think we could merge this after the travis result is green.

:)

Omega, thanks for your great work!

Comment 14

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/4275ca142a71ff296be1b6b672648f13d14d3484

--
Omega, thanks again for your effort.

Comment 15

[William Hsu [:whsu]]

Verified it.
Thanks all!

* Build information:
 - Gaia      c462d9183d294a2d8ecc472f593ea8cfa15bc9de
 - Gecko     https://hg.mozilla.org/mozilla-central/rev/9d8d16695f6a
 - BuildID   20140520160203
 - Version   32.0a1

Comment 16

[William Hsu [:whsu]]

Attachment: VIsualKeyboard_0521.png