985320 - Add a static Matrix::Scaling method to Moz2D's Matrix

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jonathan Watt [:jwatt]]

We should add a Matrix::Scaling method to Moz2D's Matrix class to compliment Matrix::Translation and Matrix::Rotation.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Bas Schouten (:bas.schouten)]

Comment on attachment 8393358 [details] [diff] [review]
patch

Review of attachment 8393358 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/Matrix.h
@@ +127,5 @@
> +  {
> +    return Matrix(aX, 0.0f, 0.0f, aY, 0.0f, 0.0f);
> +  }
> +
> +  static Matrix Scaling(Size aSize)

I feel like it's wrong to Scale by a 'size'. That sort of means using 'size' as an arbitrary vector which I'd say is confusing.

Comment 3

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e455c486e2ec

I removed the Size version before pushing. There's less of a need (if any) than there is for the Point version of Translation, so we can add that (or something like it) if and when we need it.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e455c486e2ec