Closed Bug 985331 Opened 6 years ago Closed 6 years ago

[Keyboard UX update][User Story] Long press spacebar to dismiss keyboard

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

x86
Gonk (Firefox OS)
defect
Not set

Tracking

(feature-b2g:2.0)

RESOLVED FIXED
2.0 S1 (9may)
feature-b2g 2.0

People

(Reporter: bhuang, Assigned: rudyl)

References

Details

(Whiteboard: [ucid:SystemPlatform50, 2.0, ft:system-platform], [p=1])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
timdream
: review+
Omega
: ui-review+
Details | Review
As a user, I want to be able to dismiss the keyboard by long pressing the spacebar key when I no longer need the keyboard.

Acceptance:
Visual hint on spacebar to allow long press to dismiss keyboard
Long press on spacebar dismisses the keyboard

Refer to p.6 of UX spec in bug 983043
Whiteboard: [ucid:SystemPlatform50, 1.5, ft:system-platform]
See bug 983043 for the UX spec update.
Assignee: nobody → rlu
Status: NEW → ASSIGNED
Target Milestone: --- → 1.4 S6 (25apr)
Depends on: 1000095
Whiteboard: [ucid:SystemPlatform50, 1.5, ft:system-platform] → [ucid:SystemPlatform50, 1.5, ft:system-platform], [p=1]
Target Milestone: 1.4 S6 (25apr) → 2.0 S1 (9may)
Attached file Patch V1
WIP here with function and UI update.
Will ask for review after tested with Gecko patch.
Whiteboard: [ucid:SystemPlatform50, 1.5, ft:system-platform], [p=1] → [ucid:SystemPlatform50, 2.0, ft:system-platform], [p=1]
Comment on attachment 8413677 [details] [review]
Patch V1

Patch updated.

1. The first commit is to implement this feature.
2. And the 2nd one is to remove the swipe-down gesture.

Jan,

Could you please help review this?

--
Will try to add integration test after bug 995093 landed.
Attachment #8413677 - Flags: review?(janjongboom)
Comment on attachment 8413677 [details] [review]
Patch V1

Patch updated, so ask for Tim's help to review this one as well.

Tim, 

Please help review this.
Thanks.
Attachment #8413677 - Flags: review?(timdream)
Attachment #8413677 - Attachment description: WIP → Patch V1
Comment on attachment 8413677 [details] [review]
Patch V1

Omega,

Could you please help do ui review for this?
Thanks.

Let me know if you need any help to flash the build.
Attachment #8413677 - Flags: ui-review?(ofeng)
Comment on attachment 8413677 [details] [review]
Patch V1

When long-pressing on spacebar, the hint icon should still be there (it disappears in the current implementation).
Attachment #8413677 - Flags: ui-review?(ofeng) → ui-review-
Comment on attachment 8413677 [details] [review]
Patch V1

Patch updated to address Omega's comment.
Omega, could you please help to review it again?

Thanks.
Attachment #8413677 - Flags: ui-review- → ui-review?(ofeng)
Comment on attachment 8413677 [details] [review]
Patch V1

Looks good, I don't think we need two r+ for this.
Attachment #8413677 - Flags: review?(timdream)
Attachment #8413677 - Flags: review?(janjongboom)
Attachment #8413677 - Flags: review+
Comment on attachment 8413677 [details] [review]
Patch V1

Good job!
Attachment #8413677 - Flags: ui-review?(ofeng) → ui-review+
Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/5a01b73dea0cd6b2e0a8df1ed25f3c2ec9356763

--
Tim, Omega,

Thanks for the review.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Blocks: 1007055
Flags: in-testsuite+
feature-b2g: --- → 2.0
You need to log in before you can comment on or make changes to this bug.