985470 - Replace the Moz2D Matrix().Translate() calls with Matrix::Translation() for better perf

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jonathan Watt [:jwatt]]

We should replace the Moz2D Matrix().Translate() calls with Matrix::Translation() for better perf.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8393501 [details] [diff] [review]
patch

Review of attachment 8393501 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/FilterNodeSoftware.cpp
@@ +1108,5 @@
>      return nullptr;
>    }
>  
> +  Matrix transform = Matrix::Translation(srcRect.x, srcRect.y) * mMatrix *
> +                     Matrix::Translation(-aRect.x, -aRect.y);

For best performance you'd want to implement PreTranslate() and use that plus Translate() since we can do significantly less work in those cases.

Comment 3

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2cbac6fa8499

(In reply to Matt Woodrow (:mattwoodrow) from comment #2)
> For best performance you'd want to implement PreTranslate() and use that
> plus Translate() since we can do significantly less work in those cases.

PreXXX() makes the code ugly and harder to follow. We can get the same wins with some type tricks to make the compiler do the work we want while still keeping the code looking nice. I plan on doing that as a follow-up.

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/2cbac6fa8499