Closed Bug 985558 Opened 9 years ago Closed 9 years ago

Make is_wifi_enabled handle mozWifiManager states

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P3)

x86_64
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: zcampbell, Assigned: RobertC)

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
davehunt
: review+
Bebe
: review+
AndreiH
: review+
Details | Review
if we call the is_wifi_enabled property before mozWifiManager is initialised then it fails.
It should return False if mozWifiManager is not present.
Priority: -- → P3
Assignee: nobody → robert.chira
Attached file Pull request master
Attachment #8429279 - Flags: review?(florin.strugariu)
Attachment #8429279 - Flags: review?(dave.hunt)
Attachment #8429279 - Flags: review?(andrei.hutusoru)
Comment on attachment 8429279 [details] [review]
Pull request master

See pull request, I think this could be simplified.
Attachment #8429279 - Flags: review?(florin.strugariu)
Attachment #8429279 - Flags: review?(dave.hunt)
Attachment #8429279 - Flags: review?(andrei.hutusoru)
Attachment #8429279 - Flags: review-
Attachment #8429279 - Flags: review?(florin.strugariu)
Attachment #8429279 - Flags: review?(dave.hunt)
Attachment #8429279 - Flags: review?(andrei.hutusoru)
Attachment #8429279 - Flags: review-
Comment on attachment 8429279 [details] [review]
Pull request master

Just a nit and a question in the pull request. Otherwise, the patch looks good to me so long as it solves the problem we were seeing.
Attachment #8429279 - Flags: review?(dave.hunt) → review+
Comment on attachment 8429279 [details] [review]
Pull request master

Except for Dave's comment I have nothing to add
Attachment #8429279 - Flags: review?(florin.strugariu) → review+
Comment on attachment 8429279 [details] [review]
Pull request master

Lgtm, I know Robert is still testing this.
Attachment #8429279 - Flags: review?(andrei.hutusoru) → review+
https://github.com/mozilla-b2g/gaia/commit/e0b71a9279df193aa11d1dc8381252ff90fab1c5
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
The issue reappeared in the latest master test run.
http://selenium.qa.mtv2.mozilla.com:8080/view/B2G/job/b2g.hamachi.mozilla-b2g30_v1_4.ui.smoketest/64/HTML_Report/

This needs further investigation.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I will uplift the commit to v1.4
v1.4:
https://github.com/mozilla-b2g/gaia/commit/5d67105bc0107ac1813a3a7821c8f83b76145d71
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.