985558 - Make is_wifi_enabled handle mozWifiManager states

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P3)

Description

[Zac C (:zac)]

if we call the is_wifi_enabled property before mozWifiManager is initialised then it fails.
It should return False if mozWifiManager is not present.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

We should also remove the ignored JavascriptException in https://github.com/mozilla-b2g/gaia/blob/077d32a46de12d10b3c5b1201272cb7ec2a99e5e/tests/python/gaia-ui-tests/gaiatest/tests/functional/ftu/test_ftu_skip_tour.py#L94

Comment 2

[Robert Chira [:RobertC]]

Attachment: Pull request master

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8429279 [details] [review]
Pull request master

See pull request, I think this could be simplified.

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8429279 [details] [review]
Pull request master

Just a nit and a question in the pull request. Otherwise, the patch looks good to me so long as it solves the problem we were seeing.

Comment 5

[Florin Strugariu [:Bebe]]

Comment on attachment 8429279 [details] [review]
Pull request master

Except for Dave's comment I have nothing to add

Comment 6

[[:AndreiH]]

Comment on attachment 8429279 [details] [review]
Pull request master

Lgtm, I know Robert is still testing this.

Comment 7

[Florin Strugariu [:Bebe]]

https://github.com/mozilla-b2g/gaia/commit/e0b71a9279df193aa11d1dc8381252ff90fab1c5

Comment 8

[Robert Chira [:RobertC]]

The issue reappeared in the latest master test run.
http://selenium.qa.mtv2.mozilla.com:8080/view/B2G/job/b2g.hamachi.mozilla-b2g30_v1_4.ui.smoketest/64/HTML_Report/

This needs further investigation.

Comment 9

[Zac C (:zac)]

I will uplift the commit to v1.4

Comment 10

[Zac C (:zac)]

v1.4:
https://github.com/mozilla-b2g/gaia/commit/5d67105bc0107ac1813a3a7821c8f83b76145d71