Closed Bug 985641 Opened 10 years ago Closed 10 years ago

random orange: test-session-store.js | test-session-store.js::test_restore_single_3pane_persistence + test-session-store.js::test_restore_single_3pane_persistence_again + test-session-store.js::test_message_pane_height_persistence + test-session-store.j

Categories

(Thunderbird :: Mail Window Front End, defect)

Product:
Thunderbird
Component:
Mail Window Front End
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 33.0

People

(Reporter: mkmelin, Assigned: aceman)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

WIP patch
5.20 KB, patch
standard8
: review+
Details | Diff | Splinter Review 
https://tbpl.mozilla.org/php/getParsedLog.php?id=36333432&tree=Thunderbird-Trunk&full=1#error0

SUMMARY-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\session-store\test-session-store.js | test-session-store.js::test_restore_single_3pane_persistence
  EXCEPTION: The message display thinks it is visible, but it should not!
    at: test-folder-display-helpers.js line 1798
       assert_message_pane_hidden test-folder-display-helpers.js:1798 5
       test_restore_single_3pane_persistence test-session-store.js:188 3
       Runner.prototype.wrapper frame.js:585 9
       Runner.prototype._runTestModule frame.js:655 9
       Runner.prototype.runTestModule frame.js:701 3
       Runner.prototype.runTestDirectory frame.js:525 7
       runTestDirectory frame.js:707 3
       Bridge.prototype._execFunction server.js:179 3
       Bridge.prototype.execFunction server.js:183 1
       Session.prototype.receive server.js:283 3
       AsyncRead.prototype.onDataAvailable server.js:88 3
SUMMARY-PASS | test-session-store.js::teardownTest
SUMMARY-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\session-store\test-session-store.js | test-session-store.js::test_restore_single_3pane_persistence_again
  EXCEPTION: The message display thinks it is visible, but it should not!
    at: test-folder-display-helpers.js line 1798
       assert_message_pane_hidden test-folder-display-helpers.js:1798 5
       test_restore_single_3pane_persistence test-session-store.js:188 3
       test_restore_single_3pane_persistence_again test-session-store.js:201 3
       Runner.prototype.wrapper frame.js:585 9
       Runner.prototype._runTestModule frame.js:655 9
       Runner.prototype.runTestModule frame.js:701 3
       Runner.prototype.runTestDirectory frame.js:525 7
       runTestDirectory frame.js:707 3
       Bridge.prototype._execFunction server.js:179 3
       Bridge.prototype.execFunction server.js:183 1
       Session.prototype.receive server.js:283 3
       AsyncRead.prototype.onDataAvailable server.js:88 3
SUMMARY-PASS | test-session-store.js::teardownTest
SUMMARY-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\session-store\test-session-store.js | test-session-store.js::test_message_pane_height_persistence
  EXCEPTION: The message display does not think it is visible, but it should!
    at: test-folder-display-helpers.js line 1761
       assert_message_pane_visible test-folder-display-helpers.js:1761 5
       test_message_pane_height_persistence test-session-store.js:244 3
       Runner.prototype.wrapper frame.js:585 9
       Runner.prototype._runTestModule frame.js:655 9
       Runner.prototype.runTestModule frame.js:701 3
       Runner.prototype.runTestDirectory frame.js:525 7
       runTestDirectory frame.js:707 3
       Bridge.prototype._execFunction server.js:179 3
       Bridge.prototype.execFunction server.js:183 1
       Session.prototype.receive server.js:283 3
       AsyncRead.prototype.onDataAvailable server.js:88 3
SUMMARY-PASS | test-session-store.js::teardownTest
SUMMARY-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\session-store\test-session-store.js | test-session-store.js::test_message_pane_width_persistence
  EXCEPTION: The message display does not think it is visible, but it should!
    at: test-folder-display-helpers.js line 1761
       assert_message_pane_visible test-folder-display-helpers.js:1761 5
       test_message_pane_width_persistence test-session-store.js:278 3
       Runner.prototype.wrapper frame.js:585 9
       Runner.prototype._runTestModule frame.js:655 9
       Runner.prototype.runTestModule frame.js:701 3
       Runner.prototype.runTestDirectory frame.js:525 7
       runTestDirectory frame.js:707 3
       Bridge.prototype._execFunction server.js:179 3
       Bridge.prototype.execFunction server.js:183 1
       Session.prototype.receive server.js:283 3
       AsyncRead.prototype.onDataAvailable server.js:88 3
SUMMARY-PASS | test-session-store.js::teardownTest
SUMMARY-PASS | test-session-store.js::test_multiple_3pane_periodic_session_persistence
SUMMARY-PASS | test-session-store.js::teardownTest
SUMMARY-PASS | test-session-store.js::test_bad_session_file_simple
SUMMARY-PASS | test-session-store.js::teardownTest
SUMMARY-PASS | test-session-store.js::test_clean_shutdown_session_persistence_simple
SUMMARY-PASS | test-session-store.js::teardownModule
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
The last one might be a different issue, sorry for marking it wrong if thats the case.
Attached patch WIP patch — — Splinter Review 
The failures can also be seen often on TB-try so we can push this there. After today's build failure is solved.
Aryx, please make a try run with this patch, mozmill is enough, but all systems.
Flags: needinfo?(archaeopteryx)
Comment on attachment 8430202 [details] [diff] [review]
WIP patch

Try run is green. Let's try it on trunk as the failures currently happen there.
Attachment #8430202 - Flags: review?(standard8)
Comment on attachment 8430202 [details] [diff] [review]
WIP patch

I did a few respins of the tests on try, and they held up green, so lets see how this goes in the real world.
Attachment #8430202 - Flags: review?(standard8) → review+
Yes, thanks.
Assignee: nobody → acelists
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/345bc274138a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 33.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: