Closed Bug 985754 Opened 11 years ago Closed 11 years ago

Update reviewer tools CSS to use media queries

Categories

(Marketplace Graveyard :: Reviewer Tools, enhancement, P4)

Product:
Marketplace Graveyard
Component:
Reviewer Tools
Version:
Avenir
Platform:
x86
macOS
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2014-04-08

People

(Reporter: robhudson, Assigned: kngo)

Details

(Whiteboard: [feature])

Currently accessing the reviewer tools using a mobile device depends on a prior call to Marketplace that passes the ?dev= query string parameter. When this call happens the middleware checks dev and sets a cookie. This cookie is then checked for other requests that don't send the ?dev= query string parameter (like reviewer tools) and determines if it should use mobile or desktop templates. This is super jank. It's also the last remnants of what is actually using the `request.DESKTOP`, et al, parameters. We should just use media queries in CSS.
Assignee: nobody → kngo
Whiteboard: [feature]
Severity: normal → enhancement
Priority: -- → P4
Target Milestone: --- → 2014-04-08
STR: Reviewer tools queue and apps review pages should look okay visually in mobile + desktop.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Is this issue related to this bug http://screencast.com/t/rpUg7hGo9k ? Thank you
Flags: needinfo?(kngo)
Kevin: Can we also get rid of these uses of the `DESKTOP` context in the templates? https://github.com/mozilla/zamboni/blob/master/mkt/reviewers/templates/reviewers/review.html#L69-L73 https://github.com/mozilla/zamboni/blob/master/mkt/developers/templates/developers/login.html#L7
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://github.com/mozilla/zamboni/commit/c9ba04be9305c5bb65af530b5fe99a7466abb3ff
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Flags: needinfo?(kngo)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.