985806 - freetype build system bases automatic detection of bzip2 and zlib on host files

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

+++ This bug was initially created as a clone of Bug #985803 +++

Freetype now finds the host harfbuzz when cross-compiling freetype for android and thus enables harfbuzz support.

The same applies to bzip2 and zlib. We can probably escape the bzip2 problem with --without-bzip2, but for zlib, we probably need something like we have for libpng. Mwu, would you mind taking this?

Comment 1

[Mike Hommey [:glandium]]

Note this bug also probably means that without zlib development files on your host system, zlib support is disabled in freetype.

Comment 2

[Michael Wu [:mwu]]

(In reply to Mike Hommey [:glandium] from comment #1)
> Note this bug also probably means that without zlib development files on
> your host system, zlib support is disabled in freetype.

freetype has its own copy of zlib that it turns on when it can't find some other copy. Still not great, since we don't want another extra copy of zlib.

Comment 3

[Michael Wu [:mwu]]

Attachment: Explicitly enable zlib and disable bzip2

Going to send off to the try server. Seems to work fine here. Also, this changes B2G's freetype to use the moz copy of zlib. Previously, it was using its internal copy.

Comment 4

[Michael Wu [:mwu]]

https://tbpl.mozilla.org/?tree=Try&rev=504f58111cde

Comment 7

[Michael Wu [:mwu]]

Attachment: Explicitly enable zlib and disable bzip2, v2

Rebased and *_CFLAGS and *_LIBS made a bit more aggressive.

Comment 8

[Michael Wu [:mwu]]

https://tbpl.mozilla.org/?tree=Try&rev=2e012d695339

Comment 9

[Mike Hommey [:glandium]]

Comment on attachment 8394582 [details] [diff] [review]
Explicitly enable zlib and disable bzip2, v2

Review of attachment 8394582 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +8967,4 @@
>     export CPPFLAGS="$CPPFLAGS $MOZ_DEBUG_FLAGS"
>     export CXXFLAGS="$CXXFLAGS $MOZ_DEBUG_FLAGS"
>     export LDFLAGS="$LDFLAGS $MOZ_DEBUG_LDFLAGS"
> +   export LIBPNG_CFLAGS="$MOZ_PNG_CFLAGS "

Please add a comment about the space, so that nobody thinks of removing them later on.

Comment 10

[Michael Wu [:mwu]]

Comment added.

https://hg.mozilla.org/integration/b2g-inbound/rev/2378f03042a2

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/2378f03042a2

Comment 12

[Kai-Zhen Li [:seinlin][:kli]]

Freetype 2.5.2 do not need this.