Closed Bug 985814 Opened 8 years ago Closed 8 years ago

Skia cannot compile properly for Qt Widget backend

Categories

(Core :: Graphics, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: tatiana, Assigned: tatiana)

Details

Attachments

(1 file)

I see bunch of linker errors with current skia make files when compile for Qt Widget backend:

_Z8SkDebugfPKcz' which may overflow at runtime; recompile with -fPIC
 7:08.00 ../../build/unix/gold/ld: error: mozilla-central/obj-ff-qt/toolkit/library/../../gfx/skia/SkUtils_opts_SSE2.o: requires dynamic R_X86_64_PC32 reloc against '_Z8SkDebugfPKcz' which may overflow at runtime; recompile with -fPIC
 7:08.00 ../../build/unix/gold/ld: error: read-only segment has dynamic relocations
 7:08.00 mozilla-central/gfx/2d/image_operations.cpp:487: error: undefined reference to 'SkDebugf(char const*, ...)'
 7:08.00 ../../dist/include/skia/SkColorPriv.h:234: error: undefined reference to 'SkDebugf(char const*, ...)'
 7:08.01 ../../dist/include/skia/SkColorPriv.h:235: error: undefined reference to 'SkDebugf(char const*, ...)'
 7:08.01 ../../dist/include/skia/SkColorPriv.h:236: error: undefined reference to 'SkDebugf(char const*, ...)'
 7:08.01 mozilla-central/gfx/2d/ScaledFontCairo.cpp:57: error: undefined reference to 'SkCreateTypefaceFromCairoFont(_cairo_font_face*, SkTypeface::Style, bool)'
 7:08.01 mozilla-central/gfx/skia/trunk/src/core/SkData.cpp:97: error: undefined reference to 'sk_fmmap(SkFILE*, unsigned long*)'
 7:08.01 mozilla-central/gfx/skia/trunk/src/core/SkData.cpp:117: error: undefined reference to 'sk_fdmmap(int, unsigned long*)'
Assignee: nobody → tanya.meshkova
Status: NEW → ASSIGNED
Attachment #8393928 - Flags: review?(gwright)
Comment on attachment 8393928 [details] [diff] [review]
Fixed Qt Build skia + geolocation pieces

Review of attachment 8393928 [details] [diff] [review]:
-----------------------------------------------------------------

I assume moz.build in gfx/skia was manually updated? If so it looks like you missed updating the if statement for SK_FONTHOST_DOES_NOT_USE_FONTMGR to be defined.
Attachment #8393928 - Flags: review?(gwright) → review+
https://hg.mozilla.org/mozilla-central/rev/120de5eefe74
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.