Closed Bug 985836 Opened 6 years ago Closed 6 years ago

Move -Fd flags from configure to config.mk

Categories

(Firefox Build System :: General, defect)

All
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla31

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file, 1 obsolete file)

The reference to a make variable defined in config.mk from HOST_CFLAGS/CFLAGS/CXXFLAGS is not really helpful. It also makes it hard to remove them (which i need to for the initial sccache support for windows)
Note I'm keeping HOST_PDBFILE because it's used elsewhere, which is not
the case of COMPILE_PDBFILE.
As a consequence. we may be using the same pdb file for host object files
and host executables if they happen to have the same base name, but this
is not something I'm changing here.

https://tbpl.mozilla.org/?tree=Try&rev=e0ae8801190d
Attachment #8394009 - Flags: review?(mshal)
Attachment #8394009 - Flags: review?(mshal) → review+
This actually needs to be ?= for an easier override from mozconfig.
Attachment #8396071 - Flags: review?(mshal)
Attachment #8394009 - Attachment is obsolete: true
Attachment #8396071 - Flags: review?(mshal) → review+
https://hg.mozilla.org/mozilla-central/rev/618f5a0fda77
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.