985848 - Assume DragonFly uses DPorts for V4L2 header location

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Jan Beich]

Attachment: switch to linux/videodev2.h

DragonFly 3.6 switched from PkgSrc to DPorts being used by default. video(4) interface isn't supported natively and DragonFly plans to use USB4BSD stack for ports like multimedia/webcamd.

http://www.dragonflybsd.org/release36/
https://github.com/DragonFlyBSD/DPorts/blob/master/multimedia/v4l_compat/pkg-plist

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8393980 [details] [diff] [review]
switch to linux/videodev2.h

Review of attachment 8393980 [details] [diff] [review]:
-----------------------------------------------------------------

well, r+ in that it won't break anything else, but:
is there any concern about building this on an older DragonFly system?

Comment 2

[Jan Beich]

Would be nice to have on Aurora because bug 916427 there adds support in libsctp. However, WebRTC still doesn't build due to bug 916589.

(In reply to Randell Jesup [:jesup] from comment #1)
> is there any concern about building this on an older DragonFly system?

Unlikely to be an issue according to #dragonflybsd@efnet:

<jbeich> What's the earliest supported release? I want to know whether to
         expect PkgSrc or DPorts upstream.
<marino_> jbeich: df 3.4 for dports packages
<marino_> jbeich: pkgsrc not suppported at all right now
<marino_> jbeich: and in practical terms 3.4 isn\t
<marino_> is not getting a lot of updates anymore

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/00dc1f6aec5a

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8393980 [details] [diff] [review]
switch to linux/videodev2.h

[Approval Request Comment]
Bug caused by (feature/regressing bug #): N/A

User impact if declined: Issues building Aurora for current DragonflyBSD

Testing completed (on m-c, etc.): Built by BSD maintainer

Risk to taking this patch (and alternatives if risky): None.  Change can only affect Dragonfly BSD, no mainline platform, and simply brings it into line with linux builds.

String or IDL/UUID changes made by this patch: none

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8393980 [details] [diff] [review]
switch to linux/videodev2.h

NPOTB doesn't need approval.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/76be3ada1f32

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/00dc1f6aec5a