Closed Bug 985849 Opened 6 years ago Closed 6 years ago

[Settings] Add icons to Volume adjustment Seek Bar

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Carol, Assigned: nefzaoui)

References

Details

(Whiteboard: [good first bug][mentor=arthurcc] ux-tracking, visual design, visual-tracking, bokken )

Attachments

(5 files)

Need Sound(min)& Sound(max) icons for the seek bar in Volume adjustment on "Sound" page. I'll upload the Visual spec later.
Blocks: SysFE
Attached file Volume_asset.zip
The attachment is the images and UI spec for Volume seeker layout revise, thanks!
Flags: needinfo?(arthur.chen)
Flags: needinfo?(arthur.chen)
Whiteboard: [good first bug][mentor=arthurcc]
Target Milestone: --- → 1.5 S1 (9may)
Hi there. I'm newbie and I want to work on this bug. Can I be assigned to this?
Flags: needinfo?(arthur.chen)
Here you are. Let me know if you need any help!
Assignee: nobody → akhilnaik.aries
Flags: needinfo?(arthur.chen)
Can you provide me with further information on how and where to modify the code?
Flags: needinfo?(arthur.chen)
No longer blocks: SysFE
Whiteboard: [good first bug][mentor=arthurcc] → [good first bug][mentor=arthurcc] ux-tracking, visual design, visual-tracking, bokken
Target Milestone: 1.5 S1 (9may) → ---
Hello :)
I just wanted to mention that whoever takes this *please* consider making it RTL-compatible. Which means reversing icons positions when the layout is in RTL (Right To Left) mode (Screen Brightness seek bar is a good example).
Thank you
Flags: needinfo?(ofeng)
Ahmed, thanks for reminding!

AkhilNaik, please refer to the display panel, where we already have similar works.
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/style/settings.css#L490
Flags: needinfo?(arthur.chen)
See Bug 991026 for the Sound UX spec update.
Flags: needinfo?(ofeng)
AkhilNaik, do you need any help?
Flags: needinfo?(akhilnaik.aries)
Assignee: akhilnaik.aries → nobody
Flags: needinfo?(akhilnaik.aries)
I'll take it then and try to get a PR ready by the end of today.
Assignee: nobody → nefzaoui.ahmed
Attached file PR to Github
Assets are compressed, patch is also RTL-compatible.
Attaching RTL and LTR screenshots.
PS: I only have a Geeksphone Peak, didn't test on a @1x device. however I guess it should be OK.
Review please? :)

Thanks
Attachment #8406124 - Flags: review?(arthur.chen)
Comment on attachment 8406124 [details] [review]
PR to Github

AkhilNaik, thank you for the patch! 

It is pretty close and we need a few adjustments, please check my github comment, thanks!
Attachment #8406124 - Flags: review?(arthur.chen)
Comment on attachment 8406124 [details] [review]
PR to Github

Ummmm just a little reminder that AkhilNaik dropped the assignment. So it's Ahmed actually..
Anyway, thanks for the PR comments, I just addressed them.
Review please?
Attachment #8406124 - Flags: review?(arthur.chen)
Comment on attachment 8406124 [details] [review]
PR to Github

Thanks for the prompt response, Ahmed! r=me.
Attachment #8406124 - Flags: review?(arthur.chen) → review+
master: 37d029e584d79aeaca8d30474c394eddcdfade03
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Please see Bug 991026 for the latest UX spec.
You need to log in before you can comment on or make changes to this bug.