98595 - Ability to disable lists, trees completely

Status: RESOLVED FIXED

(Core :: XUL, enhancement, P3)

Description

[varada]

Ability to disable a complete tree instead of looping through each cell and
element in it.

Comment 1

[David Hyatt]

Yes.  

The XUL schema and spec indicate that any select control should be able to be
disabled completely, so this is a XUL1.0 issue.

Marking for XUL1.0.

Comment 2

[David Hyatt]

--> hewitt

Comment 3

[[e-mail]]

Attachment: Patch for <listbox>

Comment 4

[Joe Hewitt (gone)]

We will also need skin css to make the text in the listitems look disabled. 
Also, listheaders need to look disabled and not respond to the mouse.  Also,
listboxes should become unfocusable when disabled and lose focus if they already
had it.

Comment 5

[scottputterman]

Moving Netscape owned 0.9.9 and 1.0 bugs that don't have an nsbeta1, nsbeta1+,
topembed, topembed+, Mozilla0.9.9+ or Mozilla1.0+ keyword.  Please send any
questions or feedback about this to [e-mail].  You can search for
"Moving bugs not scheduled for a project" to quickly delete this bugmail.

Comment 6

[John Morrison]

Adding nsbeta1 and unsetting milestone to have this reevaluated. This is 
tagged for xul1.0 (ergo mozilla 1.0) [xul1.0-widgets-lists]

Comment 7

[Peter Trudelle]

nsbeta1- per Nav triage team, ->1.2

Comment 8

[[e-mail]]

Attachment: New <listbox> patch

Comment 9

[Jan Varga [:janv]]

Comment on attachment 107461 [details] [diff] [review]
New <listbox> patch

looks good
r=varga

Comment 10

[Jan Varga [:janv]]

>We will also need skin css to make the text in the listitems look disabled. 
>Also, listheaders need to look disabled and not respond to the mouse.
This is done in Neil's patch

>Also, listboxes should become unfocusable when disabled and lose focus if they
>already had it.

this also works with this patch as expected, but I don't see where it is done 
is it done automatically for any XUL element ?

keyboard events are disabled too, but again I don't see where they are disabled

This is probably a known behaviour that I'm not aware of, sigh

Comment 11

[Steffen Wilberg]

What's the status of this?
Hewitt is gone. I guess he won't sr this anymore.

Comment 12

[Jan Varga [:janv]]

*** Bug 245446 has been marked as a duplicate of this bug. ***

Comment 13

[[e-mail]]

*** Bug 270284 has been marked as a duplicate of this bug. ***

Comment 14

[[e-mail]]

Comment on attachment 107461 [details] [diff] [review]
New <listbox> patch

I didn't check in the parts corresponding to the disabled listheaders because
I'm not happy with that part of the patch. But I did remember to patch the Mac
theme.

Comment 15

[Ian Neal]

Attachment: Toolkit version of patch v0.3

Diff isn't quite right, but that is because pinstripe's listbox.css is
currently a binary file so I'll attach that as a separate file.

Comment 16

[Ian Neal]

Attachment: Pinstripe's listbox.css

Comment 17

[[e-mail]]

(In reply to comment #15)
>pinstripe's listbox.css is currently a binary file
Well, it was just checked in with the wrong line endings...

Comment 18

[Ian Neal]

Attachment: Toolkit verison of patch v0.3a (Checked in)

Comment 19

[Mike Connor [:mconnor]]

Comment on attachment 172625 [details] [diff] [review]
Toolkit verison of patch v0.3a (Checked in)

Ian, I'm not likely to get to this in a timely fashion.  There's a number of
toolkit reviewers listed in owners.html that can be asked.

Comment 20

[Mike Kaply [:mkaply]]

Comment on attachment 172625 [details] [diff] [review]
Toolkit verison of patch v0.3a (Checked in)

r=mkaply

Comment 21

[Ian Neal]

Comment on attachment 172625 [details] [diff] [review]
Toolkit verison of patch v0.3a (Checked in)

Checking in content/widgets/listbox.xml;
/cvsroot/mozilla/toolkit/content/widgets/listbox.xml,v	<--  listbox.xml
new revision: 1.10; previous revision: 1.9
done
Checking in themes/qute/global/listbox.css;
/cvsroot/mozilla/toolkit/themes/qute/global/listbox.css,v  <--	listbox.css
new revision: 1.4; previous revision: 1.3
done
Checking in themes/winstripe/global/listbox.css;
/cvsroot/mozilla/toolkit/themes/winstripe/global/listbox.css,v	<-- 
listbox.css

new revision: 1.6; previous revision: 1.5
done

Comment 22

[Aaron Leventhal]

We need to test to make sure the disabled widgets are also marked disabled in
the accessibility interfaces. Any testcases or examples of this in the current
builds' UI?

Comment 23

[Alex Vincent [:WeirdAl]]

Okay, so outliners have now been adopted into the more generic <xul:tree/> widget.  hewitt's no longer with us, so I'm reassigning to default owner/QA.

I'll take a stab at creating a patch for trees.

Comment 24

[Alex Vincent [:WeirdAl]]

Hm.  On careful testing in Firefox 1.5 and SeaMonkey trunk, key presses are disabled, but the user can still click around the tree.  Firefox's tree looks like it's disabled, but styling of the treechildren with a background color shows this isn't quite the case.

Comment 25

[Alex Vincent [:WeirdAl]]

Attachment: <xul:tree disabled="true"/>

This is a pretty simple solution:  we simply stop the event and cancel its default before letting it get to any treechildren elements.  Trying to stop it at the treechildren would mean knowing how to reach the tree element, and that would have been a bit longer path than I'd want to take.

This patch doesn't fix the styling of disabled trees for SeaMonkey.  I figure that belongs to a different bug.

Comment 26

[Alex Vincent [:WeirdAl]]

Attachment: testcase

I'm rethinking whether the patch I submitted is the best solution:
<NeilAway> all disabled xul controls still get events

My patch doesn't do that.

Comment 27

[Alex Vincent [:WeirdAl]]

Attachment: <xul:tree disabled="true"/> better patch

I'd miscalculated; only the topmost treechildren descendant (the child) of the tree element implements tree.xml#treebody.  So it was a matter of referring to this.parentNode instead of this, like the rest of the treebody binding does.

Comment 28

[Alex Vincent [:WeirdAl]]

Attachment: scrollable tree testcase

timeless asked for a scrollable tree testcase.  Here it is.  I think the behavior is still correct.

Comment 29

[Alex Vincent [:WeirdAl]]

patch checked in by timeless.  Thanks, everyone.