use of NS_ERROR_NO_CONTENT from the URILoader causes an assert

RESOLVED FIXED

Status

()

RESOLVED FIXED
17 years ago
17 years ago

People

(Reporter: blizzard, Assigned: blizzard)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [xremote])

Attachments

(2 attachments)

(Assignee)

Description

17 years ago
The use of NS_ERROR_NO_CONTENT() from nsMailtoChannel::AsyncOpen() has caused
problems when loading mailto: urls from the URILoader.  It looks like the
docshell code was patched to handle this error condition but the URI Loader
hasn't been.  Patch to follow.
(Assignee)

Comment 1

17 years ago
Created attachment 48465 [details] [diff] [review]
uriloader patch
(Assignee)

Comment 2

17 years ago
I need review/super-review from you guys since this seems to be your area.  I
need this for X Remote fixes.
Whiteboard: [xremote]
(Assignee)

Updated

17 years ago
Blocks: 98603

Comment 3

17 years ago
oops, you're right... 

I think that a better patch would be to combine the check with 
NS_ERROR_DOM_RETVAL_UNDEFINED.  

something like this:

  if (rv == NS_ERROR_DOM_RETVAL_UNDEFINED ||
      rv == NS_ERROR_NO_CONTENT)

rather than adding another if statement

Hopefully, NS_ERROR_DOM_RETVAL_UNDEFINED is going away in favor of 
NS_ERROR_NO_CONTENT.  
No longer blocks: 98603
(Assignee)

Comment 4

17 years ago
What about the warning after the check?  It's not a warning condition, is it?

Comment 5

17 years ago
Yeah... we can lose the NS_WARNING(...).  

Updated

17 years ago
Attachment #48476 - Flags: review+

Comment 7

17 years ago
Comment on attachment 48476 [details] [diff] [review]
patch #2

sr=mscott
Attachment #48476 - Flags: superreview+
(Assignee)

Comment 8

17 years ago
Checked in.  Thanks, guys!
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.