986096 - On access to Sync through settings after setup, user should be sent to config screen not 'back to browsing'

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Aaron Train [:aaronmt]]

* Install Firefox Beta off Google Play
* Tap first-run banner, set up Sync
* Tap 'return to browsing'
* User explores settings, see's 'Sync', taps Sync again
* User expects to see config options
* User sees redundant 'return to browsing' from existing running activity

After 'returning to browsing', we should make note of that, 'close' the activity and have the user visit sync configuration options on next access attempt.

Comment 1

[Nick Alexander :nalexander [he/him]]

> After 'returning to browsing', we should make note of that, 'close' the
> activity and have the user visit sync configuration options on next access
> attempt.

Agreed.  Need to finish() the activity at

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/fxa/activities/FxAccountConfirmAccountActivity.java#65

Comment 2

[Richard Newman [:rnewman]]

Pretty sure there's already a bug on file for this.

Comment 3

[Nick Alexander :nalexander [he/him]]

(In reply to Richard Newman [:rnewman] from comment #2)
> Pretty sure there's already a bug on file for this.

There might be.  We have a bunch of "manage Activity lifecycle better" bugs; soon, we'll track a meta bug and actually try to make this better.

Comment 4

[Richard Newman [:rnewman]]

I'm just gonna fix this.

Comment 5

[Richard Newman [:rnewman]]

Nick reviewed on IRC, and I made some trivial extensions.

https://hg.mozilla.org/integration/fx-team/rev/3800705bc851

If this tracks, I'll request uplift.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3800705bc851

Comment 7

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed on:
Builds:
Nightly (2014-05-12)
Aurora (2014-05-12)

Devices:
Galaxy Nexus (Android 4.2.1)
Samsung S3 (Android 4.3)

Comment 8

[Flaviu Cos]

Considering that the Firefox 30 has landed I will change flags from FF29 and FF30 to wontfix;
Based on comment 7 I will mark the bug as verified.