986165 - [keyboard] Bubble text is visible to screen reader users.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Eitan Isaacson [:eeejay]]

STR:

1. Activate screen reader.
2. Navigate to a text entry, and double tap.
3. Move finger over keyboard.

Result: In English/US keyboard you hear the label of the key twice, for example "L L", or "U U".
Expected: Only hear the label once.

This is due to the bubble text not being hidden properly. opacity: 0 is not enough to properly hide it.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17400

Simple!

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8394415 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17400

r=me.
Thanks.

I think then we don't need the opacity rule, right?

Comment 3

[Eitan Isaacson [:eeejay]]

(In reply to Rudy Lu [:rudyl] from comment #2)
> Comment on attachment 8394415 [details] [review]
> Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17400
> 
> r=me.
> Thanks.
> 
> I think then we don't need the opacity rule, right?

Indeed! I'll do that.

Comment 4

[Eitan Isaacson [:eeejay]]

https://github.com/mozilla-b2g/gaia/commit/1b09260a50735342d04dd9ec3e1f99c2c3909ec9

Comment 5

[Anthony Ricaud (:rik)]

Eitan: Can you make sure that they are no reflows happening after this change when we press a key? It shouldn't but sometimes Gecko triggers reflows when it shouldn't. You can use the Developer hud to check that.

Comment 6

[Eitan Isaacson [:eeejay]]

(In reply to Anthony Ricaud (:rik) [out March 27 & 28] from comment #5)
> Eitan: Can you make sure that they are no reflows happening after this
> change when we press a key? It shouldn't but sometimes Gecko triggers
> reflows when it shouldn't. You can use the Developer hud to check that.

I'm seeing a reflow both with and without this patch :(

Comment 7

[Anthony Ricaud (:rik)]

Vivien: I thought we got rid of all the reflows on key press in the keyboard, is it expected that we still see one?

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Anthony Ricaud (:rik) [out March 27 & 28] from comment #7)
> Vivien: I thought we got rid of all the reflows on key press in the
> keyboard, is it expected that we still see one?

It's not expected. There should be no reflows related to a key press / key release. But you need to disable the autocompletion to verify this as this one trigger separate reflows.

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Eitan can you double check ?

Comment 10

[Eitan Isaacson [:eeejay]]

I disabled the word suggestions, and now we are at 0 reflows, both with and without the patch. So we are good!