Closed Bug 986166 Opened 10 years ago Closed 5 years ago

Intermittent browser_dbg_variables-view-edit-click.js | The expression should indicate it is still being edited after a click. - Got false, expected true

Categories

(DevTools :: Debugger, defect, P3)

x86
Windows XP
defect

Tracking

(firefox29 unaffected, firefox30 disabled, firefox31 disabled, firefox-esr24 unaffected)

RESOLVED FIXED
Tracking Status
firefox29 --- unaffected
firefox30 --- disabled
firefox31 --- disabled
firefox-esr24 --- unaffected

People

(Reporter: RyanVM, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure, Whiteboard: [test disabled on OSX & Win debug])

Attachments

(1 file)

https://tbpl.mozilla.org/php/getParsedLog.php?id=36449945&tree=Mozilla-Inbound

Windows XP 32-bit mozilla-inbound pgo test mochitest-browser-chrome on 2014-03-20 09:03:35 PDT for push 260154a65e57
slave: t-xp32-ix-058

09:18:43     INFO -  TEST-START | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_variables-view-edit-click.js
09:18:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_variables-view-edit-click.js | Initializing a debugger panel.
09:18:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_variables-view-edit-click.js | Adding tab: http://example.com/browser/browser/devtools/debugger/test/doc_watch-expressions.html
09:18:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_variables-view-edit-click.js | Tab added and finished loading: http://example.com/browser/browser/devtools/debugger/test/doc_watch-expressions.html
09:18:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_variables-view-edit-click.js | Debugee tab added successfully: http://example.com/browser/browser/devtools/debugger/test/doc_watch-expressions.html
09:18:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_variables-view-edit-click.js | Debugger panel shown successfully.
09:18:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_variables-view-edit-click.js | Debugger client resumed successfully.
09:18:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_variables-view-edit-click.js | Waiting for debugger event: 'Debugger:FetchedWatchExpressions' to fire: 1 time(s).
09:18:44     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_variables-view-edit-click.js | Debugger event 'Debugger:FetchedWatchExpressions' fired: 1 time(s).
09:18:44     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_variables-view-edit-click.js | Enough 'Debugger:FetchedWatchExpressions' panel events have been fired.
09:18:44     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_variables-view-edit-click.js | The expression should indicate it is not being edited.
09:18:44     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_variables-view-edit-click.js | The expression should indicate it is being edited.
09:18:44     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_variables-view-edit-click.js | The expression text should be selected.
09:18:44  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_variables-view-edit-click.js | The expression should indicate it is still being edited after a click. - Got false, expected true
09:18:44     INFO -  Stack trace:
09:18:44     INFO -      JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 714
09:18:44     INFO -      JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_variables-view-edit-click.js :: test/< :: line 39
09:18:44     INFO -      JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 282
09:18:44     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 118
09:18:44     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 43
09:18:44     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 185
09:18:44     INFO -      JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/head.js :: onEvent :: line 343
09:18:44     INFO -      JS frame :: resource://gre/modules/devtools/event-emitter.js :: EventEmitter_emit :: line 131
09:18:44     INFO -      JS frame :: chrome://browser/content/devtools/debugger-controller.js :: StackFrames.prototype._fetchWatchExpressions/< :: line 936
09:18:44     INFO -      JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DebuggerClient.requester/</< :: line 328
09:18:44     INFO -      JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js :: makeInfallible/< :: line 80
09:18:44     INFO -      JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DebuggerClient.prototype.onPacket/< :: line 727
09:18:44     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 118
09:18:44     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 43
09:18:44     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 153
09:18:44     INFO -      JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DebuggerClient.prototype.onPacket :: line 731
09:18:44     INFO -      JS frame :: resource://gre/modules/devtools/dbg-client.jsm -> resource://gre/modules/devtools/server/transport.js :: LDT_send/< :: line 258
09:18:44     INFO -      JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js :: makeInfallible/< :: line 80
09:18:44     INFO -      JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/server/actors/script.js :: EventLoop.prototype.enter :: line 387
09:18:44     INFO -      JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/server/actors/script.js :: ThreadActor.prototype._pushThreadPause :: line 557
09:18:44     INFO -      JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/server/actors/script.js :: ThreadActor.prototype._pauseAndRespond :: line 840
09:18:44     INFO -      JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/server/actors/script.js :: ThreadActor.prototype.onDebuggerStatement :: line 2169
09:18:44     INFO -      JS frame :: http://example.com/browser/browser/devtools/debugger/test/doc_watch-expressions.html :: ermahgerd :: line 18
09:18:44     INFO -      JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_variables-view-edit-click.js :: test/</< :: line 20
09:18:44     INFO -      JS frame :: chrome://mochikit/content/browser-test.js :: testScope/test_executeSoon/<.run :: line 743
09:18:44     INFO -      native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
09:18:44     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_variables-view-edit-click.js | The expression text should not be selected.
09:18:44     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_variables-view-edit-click.js | The expression should indicate it is not being edited after cancelling.
09:18:44     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_variables-view-edit-click.js | Destroying the specified debugger.
09:18:44     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_variables-view-edit-click.js | Waiting for event: 'Debugger:Shutdown' on [object ChromeWindow].
09:18:44     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_variables-view-edit-click.js | Waiting for event: 'destroyed' on [object Object].
09:18:44     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_variables-view-edit-click.js | Removing tab.
09:18:44     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_variables-view-edit-click.js | Tab removed and finished closing.
09:18:44     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_variables-view-edit-click.js | finish() was called, cleaning up...
09:18:44     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_variables-view-edit-click.js | Forcing GC after debugger test.
09:18:44     INFO -  TEST-INFO | MEMORY STAT vsize after test: 713773056
09:18:44     INFO -  TEST-INFO | MEMORY STAT vsizeMaxContiguous after test: 311427072
09:18:44     INFO -  TEST-INFO | MEMORY STAT residentFast after test: 431603712
09:18:44     INFO -  TEST-INFO | MEMORY STAT heapAllocated after test: 138945044
09:18:44     INFO -  INFO TEST-END | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_variables-view-edit-click.js | finished in 1158ms
Brandon, can you please take a look at this? We still hit this on Cedar even with the devtools tests running on their own.
Flags: needinfo?(bbenvie)
Assignee: nobody → bbenvie
Flags: needinfo?(bbenvie)
I'm guessing/hoping this is just an issue with wonky platform menu/focus issues. This is kind of a difficult thing to test cleanly because it's so tightly wound up with activating the menu, which we can't really control from JS.

On that basis, I've changed the test to attempt 5 times. While it will still be capable of intermittent failure (presumably), it should happen very rarely. We can update the retry limit if needed.

https://tbpl.mozilla.org/?tree=Try&rev=3f1c78bd1471
Attachment #8409018 - Flags: review?(vporof)
Comment on attachment 8409018 [details] [diff] [review]
vview-intermittent.patch

Review of attachment 8409018 [details] [diff] [review]:
-----------------------------------------------------------------

The type of fix here seems crude. We should disable the test for now and try investigating a bit more, hopefully determining the actual problem. Making something "try again 5 times until it works" doesn't seem like a good fix to me and could result in even flakier runs.
Attachment #8409018 - Flags: review?(vporof) → review-
Allow me.
https://hg.mozilla.org/mozilla-central/rev/63bbdca27a53
Whiteboard: [test disabled on OSX & Win debug]
Assignee: bbenvie → nobody
passing this to victor. (sorry)
Assignee: nobody → vporof
Status: NEW → ASSIGNED
The test is disabled, so no apparent urgency. I prefer leaving this open for new.
Assignee: vporof → nobody
Blocks: dbg-test
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
Bulk changing the status, as there is no assignee anymore.

Sebastian
Status: ASSIGNED → NEW
Product: Firefox → DevTools
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.