Closed Bug 986284 Opened 12 years ago Closed 12 years ago

Intermittent browser_inspector_bug_952294_tooltips_dimensions.js | Test timed out | Found a tab after previous test timed out: data:text/html,tooltip%20dimension%20test | and several leaks

Categories

(DevTools :: Inspector, defect)

Product:
DevTools
Component:
Inspector
Version:
30 Branch
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox29 wontfix, firefox30 fixed, firefox31 fixed, firefox-esr24 wontfix)

Status:
RESOLVED FIXED
Milestone:
Firefox 31
Tracking Flags:
Tracking Status
firefox29 --- wontfix
firefox30 --- fixed
firefox31 --- fixed
firefox-esr24 --- wontfix

People

(Reporter: KWierso, Assigned: pbro)

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

bug986284-intermittent-browser_inspector_bug_952294_tooltips_dimensions.js v2.patch
12.10 KB, patch
pbro
: review+
Details | Diff | Splinter Review
https://tbpl.mozilla.org/php/getParsedLog.php?id=36470492&tree=Fx-Team slave: talos-mtnlion-r5-080 15:22:46 INFO - --DOMWINDOW == 142 (0x151827710) [pid = 1264] [serial = 12607] [outer = 0x0] [url = about:blank] 15:22:46 INFO - --DOMWINDOW == 141 (0x1720a95d0) [pid = 1264] [serial = 12844] [outer = 0x0] [url = about:blank] 15:22:46 INFO - --DOMWINDOW == 140 (0x1544ef610) [pid = 1264] [serial = 12799] [outer = 0x0] [url = http://mochi.test:8888/browser/browser/devtools/inspector/test/browser_inspector_bug_848731_reset_selection_on_delete.html] 15:22:56 INFO - libpng warning: zero length keyword 15:22:56 INFO - libpng warning: Empty language field in iTXt chunk 15:22:56 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/inspector/test/browser_inspector_bug_952294_tooltips_dimensions.js | Test timed out 15:22:56 INFO - TEST-INFO | MEMORY STAT vsize after test: 4108959744 15:22:56 INFO - TEST-INFO | MEMORY STAT residentFast after test: 1001766912 15:22:56 INFO - INFO TEST-END | chrome://mochitests/content/browser/browser/devtools/inspector/test/browser_inspector_bug_952294_tooltips_dimensions.js | finished in 30156ms 15:22:56 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/inspector/test/browser_inspector_bug_952294_tooltips_dimensions.js | Found a tab after previous test timed out: data:text/html,tooltip%20dimension%20test 15:22:56 INFO - --DOCSHELL 0x12cc68f00 == 35 [pid = 1264] [id = 4846] 15:22:56 INFO - --DOCSHELL 0x14e989810 == 34 [pid = 1264] [id = 4841] 15:22:56 INFO - --DOCSHELL 0x151d8ad80 == 33 [pid = 1264] [id = 4842] 15:22:56 INFO - --DOCSHELL 0x147339140 == 32 [pid = 1264] [id = 4848] 15:22:56 INFO - --DOCSHELL 0x156cc75b0 == 31 [pid = 1264] [id = 4843] 15:22:56 INFO - --DOCSHELL 0x15406e190 == 30 [pid = 1264] [id = 4844] 15:22:56 INFO - --DOCSHELL 0x14f9961f0 == 29 [pid = 1264] [id = 4845] 15:22:56 INFO - --DOCSHELL 0x14e9520b0 == 28 [pid = 1264] [id = 4839] 15:22:56 INFO - [Parent 1264] WARNING: NS_ENSURE_TRUE(mMutable) failed: file /builds/slave/fx-team-osx64-d-00000000000000/build/netwerk/base/src/nsSimpleURI.cpp, line 265 15:22:56 INFO - TEST-INFO | checking window state LATER 16:13:32 INFO - [Parent 1264] WARNING: not an nsIRDFRemoteDataSource: 'remote != nullptr', file /builds/slave/fx-team-osx64-d-00000000000000/build/rdf/datasource/src/nsLocalStore.cpp, line 279 16:13:32 INFO - [Parent 1264] WARNING: not an nsIRDFRemoteDataSource: 'remote != nullptr', file /builds/slave/fx-team-osx64-d-00000000000000/build/rdf/datasource/src/nsLocalStore.cpp, line 279 16:13:32 INFO - [Parent 1264] WARNING: not an nsIRDFRemoteDataSource: 'remote != nullptr', file /builds/slave/fx-team-osx64-d-00000000000000/build/rdf/datasource/src/nsLocalStore.cpp, line 279 16:13:32 INFO - [Parent 1264] WARNING: not an nsIRDFRemoteDataSource: 'remote != nullptr', file /builds/slave/fx-team-osx64-d-00000000000000/build/rdf/datasource/src/nsLocalStore.cpp, line 279 16:13:32 INFO - [Parent 1264] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/slave/fx-team-osx64-d-00000000000000/build/xpcom/base/nsCycleCollector.cpp, line 3215 16:13:32 INFO - [Parent 1264] WARNING: '!compMgr', file /builds/slave/fx-team-osx64-d-00000000000000/build/xpcom/glue/nsComponentManagerUtils.cpp, line 59 16:13:32 INFO - nsStringStats 16:13:32 INFO - => mAllocCount: 18428870 16:13:32 INFO - => mReallocCount: 523091 16:13:32 INFO - => mFreeCount: 18428870 16:13:32 INFO - => mShareCount: 41810586 16:13:32 INFO - => mAdoptCount: 761264 16:13:32 INFO - => mAdoptFreeCount: 761264 16:13:32 INFO - => Process ID: 1264, Thread ID: 140735159415168 16:13:32 WARNING - TEST-UNEXPECTED-FAIL | browser/devtools/inspector/test/browser_inspector_bug_952294_tooltips_dimensions.js | leaked 2 window(s) until shutdown [url = chrome://browser/content/devtools/cssruleview.xhtml] 16:13:32 WARNING - TEST-UNEXPECTED-FAIL | browser/devtools/inspector/test/browser_inspector_bug_952294_tooltips_dimensions.js | leaked 2 window(s) until shutdown [url = about:blank] 16:13:32 WARNING - TEST-UNEXPECTED-FAIL | browser/devtools/inspector/test/browser_inspector_bug_952294_tooltips_dimensions.js | leaked 2 window(s) until shutdown [url = chrome://browser/content/devtools/framework/toolbox.xul] 16:13:32 WARNING - TEST-UNEXPECTED-FAIL | browser/devtools/inspector/test/browser_inspector_bug_952294_tooltips_dimensions.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/devtools/markup-view.xhtml] 16:13:32 WARNING - TEST-UNEXPECTED-FAIL | browser/devtools/inspector/test/browser_inspector_bug_952294_tooltips_dimensions.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/devtools/inspector/inspector.xul] 16:13:32 WARNING - TEST-UNEXPECTED-FAIL | browser/devtools/inspector/test/browser_inspector_bug_952294_tooltips_dimensions.js | leaked 1 docShell(s) until shutdown 16:13:32 INFO - INFO | runtests.py | Application ran for: 1:36:44.431745 16:13:32 INFO - INFO | zombiecheck | Reading PID log: /var/folders/s1/zw9hr_nx645fs_fbl2vmsv_h00000w/T/tmp7L9sudpidlog 16:13:32 INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, default process 1264 16:13:32 INFO - |<----------------Class--------------->|<-----Bytes------>|<----------------Objects---------------->|<--------------References-------------->| 16:13:32 INFO - Per-Inst Leaked Total Rem Mean StdDev Total Rem Mean StdDev 16:13:32 INFO - 0 TOTAL 21 0 1483778083 0 (52262.31 +/- 90345.94) 1215019406 0 (21133.73 +/- 40124.70) 16:13:33 INFO - nsTraceRefcnt::DumpStatistics: 1715 entries 16:13:33 INFO - TEST-PASS | leakcheck | no leaks detected! 16:13:33 INFO - ==> process 1273 will purposefully crash
It's again the same JS error that I've been fixing in several other tests that's causing this timeout. A rewrite of the inspector tests will fix them all once and for all. Although I think it's the last remaining intermittent in the inspector tests. I'll get to the rewrite a little bit later. For now I'll fix this test.
Assignee: nobody → pbrosset
This test had nothing to do in the inspector test folder because it only tests ruleview tooltips, so I've moved it to the styleinspector test folder. And since this folder has a new, cleaned up, head.js, I was able to rewrite the test using the new helper functions, so it's far shorter, and shouldn't fail with the race condition that has made it fail intermittently recently. Push to try: https://tbpl.mozilla.org/?tree=Try&rev=2ded26310324
Attachment #8408187 - Flags: review?(mratcliffe)
Comment on attachment 8408187 [details] [diff] [review] bug986284-intermittent-browser_inspector_bug_952294_tooltips_dimensions.js v1.patch Review of attachment 8408187 [details] [diff] [review]: ----------------------------------------------------------------- Brownie points for removing the bug number from the test filename and using hg mv to move it... I like preserving history. All splendid changes. The one nit I have is that we should be declaring the charset for our files to save log errors. r+ assuming a healthy try. ::: browser/devtools/styleinspector/test/browser_styleinspector_tooltip-size.js @@ +9,3 @@ > > +const TEST_PAGE = [ > + 'data:text/html,', 'data:text/html;charset=utf-8,',
Attachment #8408187 - Flags: review?(mratcliffe) → review+
Just added the utf-8 charset to the test markup as suggested. Try is green. Fixed in fx-team: https://hg.mozilla.org/integration/fx-team/rev/20ec0888f632
Attachment #8408187 - Attachment is obsolete: true
Attachment #8408850 - Flags: review+
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/20ec0888f632
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: