Closed Bug 986317 Opened 8 years ago Closed 8 years ago

Stop exposing urgent semantics in IPDL files

Categories

(Core :: IPC, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: billm, Assigned: billm)

Details

Attachments

(1 file)

Attached patch rm-urgentSplinter Review
Right now we have 'rpc' messages and 'urgent' messages. Urgent messages always go from the parent to the child and rpc messages always go the other way. They can nest with each other arbitrarily. Urgent messages have a crazier implementation, but from the perspective of an IPDL user, they mean the same thing (aside from direction).

Aside from simplifying things, merging rpc and urgent will allows us to define protocols that do this:

protocol PFoo {
both:
  rpc Msg();
};

I'd like to use this in the CPOW code pretty soon.

This patch just merges them in the obvious way. Anything marked as 'urgent' is renamed to 'rpc'. The IPDL code generator distinguishes them based on which direction the message needs to go.
Attachment #8394573 - Flags: review?(bent.mozilla)
Won't this dramatically affect plugins? It's a requirement that RPC messages on plugin protocols nest child-first and not parent-first, which seems to be the opposite of urgent.

Or will all of that now be handled by different MediateInterruptRace implementations for PPluginModule and PContent?
Flags: needinfo?(wmccloskey)
A while ago we did a different renaming so that plugins now use 'intr' (interrupt) messages, which are completely different. One of the reasons I want to do this is to cut down on the number of different kinds of protocols people have to remember. Right now we have sync, async, intr, urgent, and rpc. The last two were added for CPOWs.
Flags: needinfo?(wmccloskey)
Comment on attachment 8394573 [details] [diff] [review]
rm-urgent

Review of attachment 8394573 [details] [diff] [review]:
-----------------------------------------------------------------

This looks ok to me.
Attachment #8394573 - Flags: review?(bent.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/0eec23f41606
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.