Closed Bug 986360 Opened 7 years ago Closed 7 years ago

The field |flags| of the scan result from wpa_supplicant might be empty

Categories

(Firefox OS Graveyard :: Wifi, defect)

x86_64
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S4 (28mar)

People

(Reporter: hchang, Assigned: hchang)

Details

Attachments

(2 files)

http://dxr.mozilla.org/mozilla-central/source/dom/wifi/WifiWorker.js#2032

...
if (flags.indexOf("[IBSS]") >= 0)
...

|flags| might be null for test driver.
Attached patch Bug986360.patchSplinter Review
Attachment #8394646 - Flags: review?(chulee)
Comment on attachment 8394646 [details] [diff] [review]
Bug986360.patch

Review of attachment 8394646 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks you!
Attachment #8394646 - Flags: review?(chulee) → review+
Seems to be the problem of wpa_supplicant used in emulator, normally flags will contain either "[ESS]" or "[IBSS]" to indicate network type.
(In reply to Chuck Lee [:chucklee] from comment #3)
> Seems to be the problem of wpa_supplicant used in emulator, normally flags
> will contain either "[ESS]" or "[IBSS]" to indicate network type.

Thanks for the review! I agree with that wpa_supplicant is supposed to send the field |flags|.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8370c7cdec0a
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S4 (28mar)
You need to log in before you can comment on or make changes to this bug.