986360 - The field |flags| of the scan result from wpa_supplicant might be empty

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Henry Chang [:hchang]]

http://dxr.mozilla.org/mozilla-central/source/dom/wifi/WifiWorker.js#2032

...
if (flags.indexOf("[IBSS]") >= 0)
...

|flags| might be null for test driver.

Comment 1

[Henry Chang [:hchang]]

Attachment: Bug986360.patch

Comment 2

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Comment on attachment 8394646 [details] [diff] [review]
Bug986360.patch

Review of attachment 8394646 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks you!

Comment 3

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Seems to be the problem of wpa_supplicant used in emulator, normally flags will contain either "[ESS]" or "[IBSS]" to indicate network type.

Comment 4

[Henry Chang [:hchang]]

Attachment: Bug986360.patch (r+'d, add r=chulee for checkin)

Comment 5

[Henry Chang [:hchang]]

(In reply to Chuck Lee [:chucklee] from comment #3)
> Seems to be the problem of wpa_supplicant used in emulator, normally flags
> will contain either "[ESS]" or "[IBSS]" to indicate network type.

Thanks for the review! I agree with that wpa_supplicant is supposed to send the field |flags|.

Comment 6

[Carsten Book [:Tomcat]]

landed on b2g-inbound -> https://hg.mozilla.org/integration/b2g-inbound/rev/8370c7cdec0a

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8370c7cdec0a