986433 - [Messages][Refresh] Messages Inbox edit mode

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Noemí Freire (:noemi)]

Update layout to match the visual refresh proposal:
https://bug950175.bugzilla.mozilla.org/attachment.cgi?id=8370690

Comment 1

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch in github

This patch should be reviewed together with the edit mode BB patch: https://github.com/mozilla-b2g/gaia/pull/17447.patch (in case this one has landed yet)

Comment 2

[Borja Salguero [:borjasalguero]]

Comment on attachment 8396199 [details] [review]
patch in github

R+. Once BB is landed, this is working as a charm (this changes are not affecting to the current app, but when adding the BB changes changes comes directly).

Comment 3

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged: bf4333cb3cce131e51e0b8511ef11dabd86b463d

Comment 4

[Julien Wajsberg [:julienw]]

Hey, this patch removed the patch from bug 950623 and so regressed that issue.

Arnau, do you have the time to have a look?

Comment 5

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Ooops, I could not reproduce that so I removed the code. I try to remove all BB overrides when possible.

Have in mind now we will change headers for comms apps, so I didn't liked setting the color for there headers anywhere but in BB :)
I'll check that!

Comment 6

[Julien Wajsberg [:julienw]]

(In reply to Arnau March  [:arnau] from comment #5)
> Ooops, I could not reproduce that so I removed the code. I try to remove all
> BB overrides when possible.

I agree ;)
Maybe it's possible to do it in a different way, or integrated in the BB.

Please ping me on IRC if you need help reproducing it :) Should I file another bug then?

> 
> Have in mind now we will change headers for comms apps, so I didn't liked
> setting the color for there headers anywhere but in BB :)
> I'll check that!

A possibility could also be to export the colors using CSS variables.

Comment 7

[Loli (:lolimartinezcr)]

Tested and fine
Hamachi
2.0
Gecko-e4bc303
Gaia-27c85c3