remove <commandset id="composerSaveMenuItems"/> from messengercompose.xul

VERIFIED FIXED

Status

VERIFIED FIXED
17 years ago
10 years ago

People

(Reporter: sspitzer, Assigned: sspitzer)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

remove <commandset id="composerSaveMenuItems"/> from messengercompose.xul

having it causes us to overlay a some editor command stuff that we don't care
about.  (see
http://lxr.mozilla.org/mozilla/source/editor/ui/composer/content/editorOverlay.xul#122)

specificially, we do some command updating on the create and save events.

we've got File | Save (and a save button), but I'm pretty sure none of it is
hooked up to how editor does save, we do save all on our own.

obviously, before you remove it should should confirm that I'm right that we
don't need it. 
this won't be a huge performance win, but we should still get to it at some point.

Updated

17 years ago
QA Contact: sheelar → stephend
taking, I've got this in my tree.  not a big win, but still something.
Assignee: varada → sspitzer
fixed
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Created attachment 56815 [details]
Comparison of 11-2 and 10-26 builds (win32)
Ignore the typo (10-16 is actually 10-26).

Verified FIXED, based on the logs
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.