98660 - remove unnecessary calls to PR_GetEnv() [starting with PR_GetEnv("PARSE_MODE")]

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P2)

Description

[(not reading, please use [e-mail] instead)]

even in opt builds, we make calls to PR_GetEnv()

here are two that showed up while quantifying message compose:

DetermineParseMode()
COtherDTD::COtherDTD()

the complete list of calls to PR_GetEnv
http://lxr.mozilla.org/mozilla/search?string=PR_GetEnv

Comment 1

[(not reading, please use [e-mail] instead)]

I slapped a printf into PR_GetEnv() and doing 
"mozilla -console -P perf about:blank" spit this out:

(perf is my profile for perf work)

stdout directed to dynamic console
stderr directed to dynamic console
GETENV NSPR_LOG_MODULES
GETENV NSPR_LOG_MODULES
GETENV NSPR_LOG_MODULES
GETENV NSPR_LOG_MODULES
GETENV NSPR_LOG_MODULES
GETENV NSPR_LOG_MODULES
GETENV NSPR_LOG_MODULES
GETENV NSPR_LOG_MODULES
GETENV NSPR_LOG_MODULES
GETENV NSPR_LOG_MODULES
GETENV NSPR_LOG_MODULES
GETENV NSPR_FD_CACHE_SIZE_LOW
GETENV NSPR_FD_CACHE_SIZE_HIGH
GETENV NSPR_LOG_MODULES
GETENV NSPR_LOG_MODULES
GETENV MOZILLA_XPTI_STATS
GETENV MOZILLA_XPTI_REGLOG
GETENV NSPR_LOG_MODULES
GETENV PARSE_MODE
GETENV ENABLE_STRICT
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
ProfileName : perf
GETENV STRRES_ASYNC
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE
GETENV PARSE_MODE

seems like we could cache the value of PARSE_MODE, no?

Comment 2

[Chris Waterson]

Nice find seth!

Comment 3

[(not reading, please use [e-mail] instead)]

I don't see us getting hit so bad on the 2nd browser window, so maybe it is 
when we are parsing the XUL the first time?  (wild guess)

the first time I launch mail I see a bunch of calls (though not as many as the 
very first window), and much fewer calls on the second time I launch mail.

I think it costs us .01 seconds per call, so this could help first browser 
window time.

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I don't think the result of the PARSE_MODE getenv is used at all.  And if you
remove it, could you remove it on the branch only, since my patch on bug 55264
should remove it on the trunk any day now.

Comment 5

[(not reading, please use [e-mail] instead)]

will do.  here comes a branch for the 0.9.4 branch only.

Comment 6

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 48536 [details] [diff] [review]
patch

r=dbaron

Comment 8

[Simon Fraser [no longer active]]

Comment on attachment 48536 [details] [diff] [review]
patch

sr=sfraser

Comment 9

[Christopher Blizzard (:blizzard)]

Comment on attachment 48536 [details] [diff] [review]
patch

a=blizzard for 0.9.4

Comment 10

[(not reading, please use [e-mail] instead)]

fixed on 0.9.4 branch (only).