Closed Bug 986688 Opened 8 years ago Closed 8 years ago
Remove usage of Sign
In To Website .jsm
I think SignInToWebsite.jsm isn't even used at all at the moment, but it's being shipped and loaded on startup. We should fix that. (Inspired from: https://groups.google.com/forum/#!topic/mozilla.dev.platform/sAuhWQOAWic )
Right, the code shouldn't be hit unless toolkit.identity.enabled is true. I was going to put this behind the pref last year when Jared and I were looking through a similar list during a work week in Toronto last year but njn wanted to WONTFIX similar bugs saying it wasn't worth it (e.g. bug 888584 comment 2) . Now it seems we'll remove any compartment we can. I guess we were ahead of the curve. I confirmed this works locally for both states of the ifdef. Try push: https://tbpl.mozilla.org/?tree=Try&rev=59f59bb84122
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Attachment #8395173 - Flags: review?(felipc)
Attachment #8395173 - Flags: review?(felipc) → review+
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
> njn wanted to WONTFIX similar bugs saying it wasn't worth it Huh. Well there you go. Thanks for the fix!
You need to log in before you can comment on or make changes to this bug.