Closed Bug 986728 Opened 6 years ago Closed 6 years ago

HTTP cache v2: engage the frecency decay time experiment

Categories

(Core :: Networking: Cache, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: mayhemer, Assigned: mayhemer)

References

Details

Attachments

(1 file, 1 obsolete file)

I'd like to check the experiment works.  At this stage just check it doesn't crash or cause any trouble.  If not, it may be left on and after we turn the cache2 on for real we will be getting first real data and determine the best value of frecency decay time ASAP.
Attached patch v1 (obsolete) — Splinter Review
With this patch we will be getting HTTP_CACHE_MISS_HALFLIFE_EXPERIMENT telemetry:
http://hg.mozilla.org/mozilla-central/annotate/c16f36021958/netwerk/protocol/http/nsHttpChannel.cpp#l99
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Attachment #8395107 - Flags: review?(jduell.mcbugs)
Attachment #8395107 - Flags: review?(jduell.mcbugs) → review+
Comment on attachment 8395107 [details] [diff] [review]
v1

Jason, according my private mail, this patch is not complete.
Attachment #8395107 - Flags: review+
Attached patch v2Splinter Review
- first, we check the _default_ value of the experiment pref (what is at firefox.js pref file)
- if at -1, no experiment is run and we use the preferred value for frecency (6h), DONE
- if at 0, we read the user pref value (from the profile, if not set, it will return 0)
- if the user value is at 0, we randomize it (values 1,2,3,4) and persist in user's profile
- now, based on the value of the experiment pref number, we set decay time like: 1->6h, 2->1d, 3->7d, 4->50d
- the telemetry is then collected at http://hg.mozilla.org/mozilla-central/annotate/bb4dd9872236/netwerk/protocol/http/nsHttpChannel.cpp#l97 as HTTP_CACHE_MISS_HALFLIFE_EXPERIMENT
Attachment #8395107 - Attachment is obsolete: true
Attachment #8397877 - Flags: review?(jduell.mcbugs)
Comment on attachment 8397877 [details] [diff] [review]
v2

Review of attachment 8397877 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/app/profile/firefox.js
@@ +1408,5 @@
>  
>  // Delete HTTP cache v2 data of users that didn't opt-in manually
>  pref("browser.cache.auto_delete_cache_version", 1);
> +// Play with different values of the decay time and get telemetry, 0 means to randomize (and persist) the value in users' profiles
> +pref("browser.cache.frecency_experiment", 0);

> if at -1, no experiment is run and we use the preferred value for frecency (6h),

Add that to comment for the pref
Attachment #8397877 - Flags: review?(jduell.mcbugs) → review+
https://hg.mozilla.org/mozilla-central/rev/8ec512bd93d6
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Blocks: 1098422
You need to log in before you can comment on or make changes to this bug.