986763 - [Camera][Madai] Very short video not saved.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Diego Marcos [:dmarcos]]

When switching from recording to camera we stop recording. If the video recorded is very short (less than one second) it doesn't get saved and modal window with no message is displayed.

Steps to reproduce:

1. Open Camera
2. Switch to video
3. Start recording
4. Switch to photo quickly, only allowing to record a video shorter than half a second

Comment 1

[Hema Koka [:hema]]

Youngjun,

Do you have someone from your team who can investigate?

Comment 2

[Youngjun Kim]

Dear Prasad and Verchaswa,

Can you take this issue?

Comment 3

[ver4ffos]

Dear Mr. Youngjun Kim,
We will take the issue.

Comment 4

[ver4ffos]

Mr. Diego,

Need your opinion:
Should not we disable the switch mode button when recording? This will avoid the issue.
Why we need to enable switch mode button, when recording is going on? The scenario.

Comment 5

[Diego Marcos [:dmarcos]]

I created a simple patch to hide the switch button while recording video

Comment 6

[Diego Marcos [:dmarcos]]

Attachment: Pull Request on camera-new-features

Comment 7

[ver4ffos]

Patch is tested and it is working fine.

Comment 8

[David Flanagan [:djf]]

Comment on attachment 8396264 [details] [review]
Pull Request on camera-new-features

Transferring review to Justin

Comment 9

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8396264 [details] [review]
Pull Request on camera-new-features

Diego: This looks good, but needs rebased for master now that camera-new-features has landed.

Comment 10

[Hema Koka [:hema]]

Before marking this fix, please ensure this case works...

> 
> Here are the steps from Qualcomm
> 
>     Go to camera app, and switch to camcorder
> 
> ·         Start recording the video
> 
> ·         Switch back to camera without stopping the recording.
> 
> ·         Recording still continues and you are able to take picture as well.
>

Comment 11

[Diego Marcos [:dmarcos]]

Attachment: Pull Request on master

Comment 12

[Diego Marcos [:dmarcos]]

Rebased patch on top of master. Carrying r+ over

Comment 13

[Diego Marcos [:dmarcos]]

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/7ae78b26ed636965fb26220a6aa169f355eff21e

Comment 14

[David Flanagan [:djf]]

Bulk edit for camera bugs.

If earlier comments do not show how this bug landed to master, it probably landed as part of https://github.com/mozilla-b2g/gaia/pull/17599 which merged the camera-new-features branch into master.

This bug was uplifted from master to v1.4 as part of https://github.com/mozilla-b2g/gaia/commit/a8190d08e61316a86bba572ba8d894d081a20530

Comment 15

[sarsenyev]

Verified the bug is fixed, switch mode is disabled during recording


1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140408000202
Gaia: 26983f356ecb1bcf30e862d334b5de790071803e
Gecko: 70b076fc7558
Version: 30.0a2
Firmware Version: v1.2-device.cfg

1.5 Environmental Variables:
Device: Buri Master 
BuildID: 20140408040204
Gaia: 1958454595b1fa0e061f0652ae965629993f5708
Gecko: 8883360b1edb
Version: 31.0a1
Firmware Version: v1.2-device.cfg