986784 - Menu button icon looks like it is higher in the toolbar than other buttons

Status: RESOLVED WONTFIX

(Firefox :: Toolbars and Customization, defect)

Description

[Akshat Kedia [:aks]]

Attachment: Aurora 30

The toolbar icons after the Aurora 30 update have a size discrepancy. 
This discrepancy was not present in Aurora 29.

Comment 1

[Akshat Kedia [:aks]]

Attachment: Aurora 29

Comment 2

[:Gijs (he/him)]

Does this happen with a clean profile?

Comment 3

[Akshat Kedia [:aks]]

No I am not able to reproduce the bug in a clean profile. Although the menu button does look a bit misaligned from the rest don't you think so ?

Comment 4

[Akshat Kedia [:aks]]

Attachment: Aurora 30 Clean.JPG

Comment 5

[:Gijs (he/him)]

I actually kind of agree, and looking at the DOM structure, the icon is exactly at the same y-position as the icon of e.g. the home button, and the exact same size. Looking at the sprite sheet, it seems like the button is positioned slightly higher. Stephen, is that just me?

Comment 6

[Stephen Horlander [:shorlander]]

(In reply to :Gijs Kruitbosch from comment #5)
> I actually kind of agree, and looking at the DOM structure, the icon is
> exactly at the same y-position as the icon of e.g. the home button, and the
> exact same size. Looking at the sprite sheet, it seems like the button is
> positioned slightly higher. Stephen, is that just me?

If we are referring to the way it is supposed to look by default, then yes it is 1px higher in the canvas than the other icons because it has an odd sized height.

The problem shown attachment 8395155 [details] looks to be caused by the navBar being taller stretched and the menu button stretching with it.

Comment 7

[:Gijs (he/him)]

(In reply to Stephen Horlander [:shorlander] from comment #6)
> The problem shown attachment 8395155 [details] looks to be caused by the
> navBar being taller stretched and the menu button stretching with it.

In this case it doesn't make sense that the icons are both displayed at the same y coordinates, though (which is certainly what DOMI says). Please ignore the attachment you referenced and instead look at attachment 8395266 [details]. :-)

Comment 8

[Stephen Horlander [:shorlander]]

(In reply to :Gijs Kruitbosch from comment #7)
> (In reply to Stephen Horlander [:shorlander] from comment #6)
> > The problem shown attachment 8395155 [details] looks to be caused by the
> > navBar being taller stretched and the menu button stretching with it.
> 
> In this case it doesn't make sense that the icons are both displayed at the
> same y coordinates, though (which is certainly what DOMI says). Please
> ignore the attachment you referenced and instead look at attachment 8395266 [details]
> [details]. :-)

Yes, it's 1px higher visually than the other icons because it has an odd height. i.e. there is no way to vertically center it without changing the height of the icon.