Closed
Bug 986857
Opened 11 years ago
Closed 11 years ago
Replace the Attr element getters by something that returns an Element
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: ehsan.akhgari, Assigned: ayg)
References
Details
Attachments
(1 file)
|
12.21 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #957652 +++
Replace Attr::GetContentInternal(), nsIAttribute::GetContent(), and Attr::GetElement() by a non-virtual Element* nsIAttribute::GetElement(), I think. (Maybe implemented out-of-line in Attr.cpp.)
(Note that bug 957652 did this but it got backed out.)
|
Assignee | |
Comment 1•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=8ea413f294fc
Is this the right idea? I just took your patch and adapted it, but I don't know if there are other pieces from previous patches that are essential that I missed. It compiles locally and the browser starts, but I don't know that I haven't totally broken everything.
|
||
Comment 2•11 years ago
|
||
Yes, this looks like what'd make me happy :)
|
Reporter | |
Comment 3•11 years ago
|
||
Comment on attachment 8403985 [details] [diff] [review]
Patch
I tricked bz into reviewing this!
Attachment #8403985 -
Flags: review?(ehsan) → review?(bzbarsky)
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8403985 [details] [diff] [review]
Patch
r=me
Attachment #8403985 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Flags: in-testsuite-
|
||
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•