Closed Bug 986857 Opened 8 years ago Closed 7 years ago

Replace the Attr element getters by something that returns an Element

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: ehsan.akhgari, Assigned: ayg)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #957652 +++

Replace Attr::GetContentInternal(), nsIAttribute::GetContent(), and Attr::GetElement() by a non-virtual Element* nsIAttribute::GetElement(), I think. (Maybe implemented out-of-line in Attr.cpp.)

(Note that bug 957652 did this but it got backed out.)
Attached patch PatchSplinter Review
https://tbpl.mozilla.org/?tree=Try&rev=8ea413f294fc

Is this the right idea?  I just took your patch and adapted it, but I don't know if there are other pieces from previous patches that are essential that I missed.  It compiles locally and the browser starts, but I don't know that I haven't totally broken everything.
Assignee: nobody → ayg
Status: NEW → ASSIGNED
Attachment #8403985 - Flags: review?(ehsan)
Yes, this looks like what'd make me happy :)
Comment on attachment 8403985 [details] [diff] [review]
Patch

I tricked bz into reviewing this!
Attachment #8403985 - Flags: review?(ehsan) → review?(bzbarsky)
Comment on attachment 8403985 [details] [diff] [review]
Patch

r=me
Attachment #8403985 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/58ec51533237
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.