986933 - Add multi-threaded PGrallocBufferChild deallocation to ImageBridgeChild

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Sotaro Ikeda [:sotaro]]

In GrallocTextureClientOGL::~GrallocTextureClientOGL(), there is a case that SurfaceDescriptor is deallocated by calling ISurfaceAllocator::DestroySharedSurface(). But the function seems needed to be called from IPC thread. But GrallocTextureClientOGL's destructor could be called from non IPC thread.

Comment 1

[Sotaro Ikeda [:sotaro]]

shmem deallocation case is protected by ImageBridgeChild::DeallocShmem(ipc::Shmem& aShmem). But PGrallocBufferChild's deallocation does not have such code to protect from off ipc thread deallocation.

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add DeallocGrallocBuffer()

Comment 3

[Sotaro Ikeda [:sotaro]]

https://tbpl.mozilla.org/?tree=Try&rev=9aab41f5eec6

Comment 4

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #3)
> https://tbpl.mozilla.org/?tree=Try&rev=9aab41f5eec6

A lot of build failure on some platforms.

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: patch v2 - Add DeallocGrallocBuffer()

Fix build failure on linux.

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: patch v2 - Add DeallocGrallocBuffer()

Carry "nical review+".

Comment 7

[Sotaro Ikeda [:sotaro]]

https://tbpl.mozilla.org/?tree=Try&rev=8d555a16c732

Comment 8

[Sotaro Ikeda [:sotaro]]

https://hg.mozilla.org/integration/b2g-inbound/rev/a5de023f1ecc

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a5de023f1ecc