986974 - do_QueryInterface abuse in MediaManager.cpp

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, task, P1)

Description

[[e-mail]]

The code

mVideoDevice = do_QueryObject((*sources)[0]);

or its equivalent which also appears in MediaManager.cpp is an abuse of do_QueryObject, since MediaDevice does not have an IID, so what happens is that (*sources)[0] gets reinterpreted as a MediaDevice*.

SourceSet should probably be changed to be an nsTArray<nsRefPtr<MediaDevice> >.

Comment 1

[[e-mail]]

> SourceSet should probably be changed to be an nsTArray<nsRefPtr<MediaDevice> >.

That's not going to work now because as of bug 907352 mVideoDevice and mAudioDevice are now different types.

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Cleaning up Device Interfaces component, and mass-marking old FxOS bugs as incomplete.

If any of these bugs are still valid, please let me know.

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: Bug 986974 remove unused support for QueryObject to MediaDevice r?jib

This has been unnecessary since the nsIMediaDevice intermediate pointer type
was removed in https://hg.mozilla.org/mozilla-central/rev/d48c270e62c9#l1.197.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c6e5bcb9186
remove unused support for QueryObject to MediaDevice r=jib

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/0c6e5bcb9186