987026 - Crash when adopting a focused element [@ mozilla::a11y::FocusManager::ProcessDOMFocus]

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[Jesse Ruderman]

Attachment: testcase

1. Enable accessibility by pasting the following into the Browser Console:

Components.classes["@mozilla.org/accessibilityService;1"].getService(Components.interfaces.nsIAccessibleRetrieval);

2. Load the testcase.

Comment 1

[Jesse Ruderman]

Attachment: stack+

mozilla::a11y::FocusManager::ProcessDOMFocus derefs document, then checks whether it's null :(

This might have been introduced in bug 977170. Or maybe that patch just made the problem more obvious in the source code.

Comment 2

[alexander :surkov (:asurkov)]

Attachment: patch

nothing to process if accessible doesn't exist. It's interesting though where the focus goes when focsued element gets adopted, presumably it should go to the document but if not it just disappears then it's rather usability bug and we don't care. I hope it doesn't open a hole for tricks though.

Comment 3

[alexander :surkov (:asurkov)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/f65515f94aab

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out in https://hg.mozilla.org/integration/mozilla-inbound/rev/a1223ec7312a for apparently breaking all Linux64 ASAN mochitests: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&jobname=Ubuntu%20ASAN%20VM%2012.04%20x64%20mozilla-inbound%20opt%20test%20mochitest-&rev=f65515f94aab

This doesn't really make sense to me, especially with the failure that's happening in those tests, but retriggering previous pushes didn't make them fail and everything since this landed has failed. If things are still failing on this backout, I'll comment in here and you can reland this.

Comment 5

[alexander :surkov (:asurkov)]

It doesn't make sense to me because non-a11y tests were failing as well. Also I tried a try server and it was clean. Something else must be guilty.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Yeah, bug 957965 just needed to CLOBBER. Relanded this in http://hg.mozilla.org/integration/mozilla-inbound/rev/8a05309d1921

Sorry for the churn, here.

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f65515f94aab

Comment 8

[Paul Silaghi, QA [:pauly]]

Reproduced in Nightly 2014-03-25.
Verified fixed 31.0a1 (2014-03-30), Win 7 x64.