Closed Bug 987112 Opened 6 years ago Closed 6 years ago

Remove the parentObject argument to dictionary ToObject() methods

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file)

In practice, this had better be the same as the current global on cx, since that last represents the compartment we'll put the actual dictionary object in.
Oh, and the reason this didn't use to be possible before is that we parented directly to the scope object unless a different native parent was provided.  But now we parent to the global of the scope object (as of bug 717637) for any case that doesn't provide a native parent of its own, so as long as we pass in something with the right global we're good to go.
I could have sworn I'd posted this patch....
Attachment #8398608 - Flags: review?(bobbyholley)
Whiteboard: [need review]
Attachment #8398608 - Flags: review?(bobbyholley) → review+
https://hg.mozilla.org/mozilla-central/rev/e45db0a68b4f
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.