987163 - Implement Xrays to TypedArray objects

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

Part of XrayToJS.

Given that the array contents can be be arbitrary (at least for Arrays), we should consider enforcing some of the same restrictions mentioned in bug 987111 comment 0 (in particular, not returning callables, and enforcing same-origin).

Comment 1

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=4f0a7a171002

Comment 2

[Bobby Holley (:bholley)]

This should now be ready to land. Doing a final all-platform try push to be sure: https://tbpl.mozilla.org/?tree=Try&rev=47dc2ed0e926

I'm sorry to dump this on you bz, but gabor is out until sometime next week and we're getting near the end of Q2, so I don't want this goal to slip. The patches should be very straightforward (feel free to just skim the test changes).

Comment 3

[Bobby Holley (:bholley)]

Attachment: Part 1 - Mirror the TypedArray ClassSpec between instance and proto JSClasses. v1

The Xray code expects to be able to find the ClassSpec via the JSClass of either
instances or standard prototypes. So in the case where these two objects have
different JSClasses, we need to put the information on both.

Comment 4

[Bobby Holley (:bholley)]

Attachment: Part 2 - Convert from |switch| statements to |if| statements. v1

I realized that the switches are going to be cumbersome for Array stuff, because
we'll have to enumerate each kind of TypedArray as a separate case: statement.
Let's just use |if| so that we can call a helper.

Comment 5

[Bobby Holley (:bholley)]

Attachment: Part 3 - Fix some squelched OOMs. v1

Comment 6

[Bobby Holley (:bholley)]

Attachment: Part 4 - Drop special COW support for TypedArrays. v1

From now on, if someone wants to expose a TypedArray to content, they should
use Cu.cloneInto.

Comment 7

[Bobby Holley (:bholley)]

Attachment: Part 5 - Test fixups. v1

Comment 8

[Bobby Holley (:bholley)]

Attachment: Part 6 - Implement Xrays for TypedArrays. v1

Comment 9

[Bobby Holley (:bholley)]

Comment on attachment 8438872 [details] [diff] [review]
Part 2 - Convert from |switch| statements to |if| statements. v1

Looks like gabor is back, so sending this back to him.

Gabor, this should be pretty quick to review. It's also part of a Q2 goal, so if you have time to review it today I'd appreciate it. :-)

Comment 10

[Gabor Krizsanits (INACTIVE)]

Comment on attachment 8438876 [details] [diff] [review]
Part 6 - Implement Xrays for TypedArrays. v1

Review of attachment 8438876 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/wrappers/XrayWrapper.cpp
@@ +54,5 @@
> +                            key == JSProto_Uint8ClampedArray;
> +#endif
> +    bool isTypedArray = key >= JSProto_Int8Array &&
> +                        key <= JSProto_Uint8ClampedArray;
> +    MOZ_ASSERT(isTypedArray == isTypedArraySlow, "Somebody reordered jsprototypes.h!");

Could you also assert that the difference of JSProto_Uint8ClampedArray and JSProto_Int8Array has not changed? Since if someone adds a new type before JSProto_Uint8ClampedArray nothing will alarm without that.

Comment 11

[Bobby Holley (:bholley)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/49ee19d05a74
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/211c785e34bb
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/a8ca188e4c66
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/562536284927
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/bde5933787df
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/4a50fbe99969

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/49ee19d05a74
https://hg.mozilla.org/mozilla-central/rev/211c785e34bb
https://hg.mozilla.org/mozilla-central/rev/a8ca188e4c66
https://hg.mozilla.org/mozilla-central/rev/562536284927
https://hg.mozilla.org/mozilla-central/rev/bde5933787df
https://hg.mozilla.org/mozilla-central/rev/4a50fbe99969