98722 - mail js code assumes multiselection folder pane

Status: VERIFIED INVALID

(SeaMonkey :: MailNews: Message Display, defect)

Description

[[e-mail]]

My understanding is that the folder pane is single selection. This means that
code along these lines (this function in commandglue.js is actually redundant)

function GetSelectedFolderResource()
{
  var folderOutliner = GetFolderOutliner();
  var startIndex = {};
  var endIndex = {};
  folderOutliner.outlinerBoxObject.selection.getRangeAt(0, startIndex, endIndex);
  return GetFolderResource(folderOutliner, startIndex.value);
}
could actually be written

function GetSelectedFolderResource()
{
  var folderOutliner = GetFolderOutliner();
  return GetFolderResource(folderOutliner, folderOutliner.currentIndex);
}

Where you compare e.g. startIndex >= 0 you can use currentIndex there as well.

Many functions call GetSelectedFolders not realising that it returns one folder.
These functions could all be rewritten and the loops removed.

Comment 1

[Håkan Waara]

Sometime in the future we'll want to support multiple selection of folders. This
was to lessen the pain for that day (forwards compability).

Comment 2

[Henrik Lynggaard Hansen]

Giving the comment #1, shouldn't this bug have been closed a long time ago ?

It has not been touched since 2001-09-07

Comment 3

[[e-mail]]

Invalid because the right-click code now depends on this behaviour.

Comment 4

[[e-mail] (gone - use [e-mail] instead)]

verified. thanks for the explanation, neil