987275 - Make test_deleted_items more resistant against timing issues

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

The test randomly fails on windows. The use of timeouts is a bad thing. I'm introducing an internal handler for the sql calls that we can use from the tests.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Comment 2

[Mohit Kanwal [:redDragon]]

Comment on attachment 8395813 [details] [diff] [review]
Fix - v1

Review of attachment 8395813 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, just a few nits. Tested out the patch. Works fine.

::: calendar/test/unit/test_deleted_items.js
@@ +41,3 @@
>      do_check_null(delmgr.getDeletedDate("random", "random"));
>  
>      // This shouldn't throw anything

I think a more informative comment is required.

@@ +51,4 @@
>      item.startDate = cal.now();
>      item.endDate = cal.now();
>  
> +    // Add the item, it still shouldn't be in the deleted database

checkstyle: missing full stop.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v2

Patch for checkin

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/8fb24ee695c2

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix intermittent failures - v1

I made a mistake that causes intermittent test failures, executing this test in loop fails 1 out of 10 times. There are also errors on the build where bug 680203 was checked in.

This simple change fixes it, I had it running 20 minutes on loop without failure.

Comment 6

[Martin Schröder [:mschroeder]]

Comment on attachment 8409616 [details] [diff] [review]
Fix intermittent failures - v1

Using yield with a promise should work as expected, r=mschroeder.

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset 6fc71637650a