987310 - Sanitize the filter predicates loaded from the preferences

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect)

Description

[Victor Porof [:vporof][:vp]]

I accidentally modified the filter preferences to have a bogus predicate. This made the netmonitor unable to use filters at all. We should properly sanitize this.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 8395862 [details] [diff] [review]
v1

Review of attachment 8395862 [details] [diff] [review]:
-----------------------------------------------------------------

alrighty.

Comment 3

[Carsten Book [:Tomcat]]

landed as https://hg.mozilla.org/integration/fx-team/rev/dff900f56c49

Comment 4

[Victor Porof [:vporof][:vp]]

(In reply to Carsten Book [:Tomcat] from comment #3)
> landed as https://hg.mozilla.org/integration/fx-team/rev/dff900f56c49

Thank you! Please add [fixed-in-fx-team] in the whiteboard when landing on fx-team.

Comment 5

[Carsten Book [:Tomcat]]

(In reply to Victor Porof [:vporof][:vp] from comment #4)
> (In reply to Carsten Book [:Tomcat] from comment #3)
> > landed as https://hg.mozilla.org/integration/fx-team/rev/dff900f56c49
> 
> Thank you! Please add [fixed-in-fx-team] in the whiteboard when landing on
> fx-team.

np, yeah will do!

also had to back this change out, seems it caused a leak like https://tbpl.mozilla.org/php/getParsedLog.php?id=36728854&tree=Fx-Team

Comment 6

[Victor Porof [:vporof][:vp]]

That can't be caused by this patch... Please re-land this.

Comment 7

[Victor Porof [:vporof][:vp]]

Please also add the back-out changeset in the future, it's easier to track things down: https://hg.mozilla.org/integration/fx-team/rev/a26977bf2252

Comment 8

[Victor Porof [:vporof][:vp]]

Tentative reland: https://hg.mozilla.org/integration/fx-team/rev/513e425d0268
Hopefully this proves not to be the actual source of oranges.

Comment 9

[Victor Porof [:vporof][:vp]]

I've been looking into comment 5 some more, and I found something that might *potentially* be a cause for oranges.

Because of the way we lazily populate the requests menu, a timeout could fire after the test finishes, which just results in an exception being thrown. This looks harmless, but it should definitely not happen.

Although there are so many other tests that already suffer from this problem, I've fixed this, just in case it might actually be the thing that's causing things to fail at the end of the suite: https://hg.mozilla.org/integration/fx-team/rev/7f4778b94aa8

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/513e425d0268
https://hg.mozilla.org/mozilla-central/rev/7f4778b94aa8