987347 - Stub installer should use MS Shell Dlg 2 pseudo font

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Robert Strong (they/them - no direct email)]

It currently uses MS Shell Dlg 8 point and it should use MS Shell Dlg 2 8 point 

http://msdn.microsoft.com/en-us/library/windows/desktop/aa511282.aspx

Specifically:
"To target Windows® XP and Windows 2000, use the 8 point MS Shell Dlg 2 pseudo font, which maps to Tahoma.
To target earlier versions of Windows, use 8 point MS Shell Dlg pseudo font, which maps to Tahoma on Windows 2000 and Windows XP, and to MS Sans Serif on Windows 95, Windows 98, Windows Millennium Edition, and Windows NT 4.0."

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Changed nsisui.exe resource 105 as follows:

  105 DIALOGEX 0, 0, 448, 253
  STYLE DS_FIXEDSYS | DS_CENTER | WS_MINIMIZEBOX | WS_POPUP | WS_CAPTION | WS_SYSMENU
  CAPTION ""
  LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_US
- FONT 8, "MS Shell Dlg"
+ FONT 8, "MS Shell Dlg 2"
  {
     CONTROL "", 3, BUTTON, BS_PUSHBUTTON | WS_CHILD | WS_GROUP | WS_TABSTOP, 11, 223, 50, 14 
     CONTROL "", 10, BUTTON, BS_AUTOCHECKBOX | BS_VCENTER | BS_MULTILINE | WS_CHILD | WS_VISIBLE | WS_TABSTOP, 70, 217, 250, 26

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: screenshot comparison

Comment 3

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2b3772af694

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b2b3772af694