Closed Bug 987356 Opened 7 years ago Closed 7 years ago

Migrate week_view_test.js to use new "view" code

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S5 (11apr)

People

(Reporter: gaye, Assigned: evanxd)

References

Details

(Whiteboard: [p=3])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
mmedeiros
: review+
Details | Review
No description provided.
Blocks: 985219
Assignee: nobody → evanxd
Status: NEW → ASSIGNED
Whiteboard: [priority][p=3]
Whiteboard: [priority][p=3] → [p=3]
Target Milestone: --- → 1.4 S5 (11apr)
I'm making some changes to week_view test to catch a regression (Bug 989785), so this will need to wait. Sorry for that.
Depends on: 989785
Got you.
Thanks.
Assignee: evanxd → nobody
Assignee: nobody → evanxd
Attached file Pull request
Comment on attachment 8400554 [details] [review]
Pull request

Hi Miller,

Could you help me to review the patch?
Thanks.
Attachment #8400554 - Flags: review?(mmedeiros)
Comment on attachment 8400554 [details] [review]
Pull request

Sorry, we should make sure the test case could be passed for 30 times continually on Travis first, then we could do the review process.

See the 30 times result at https://travis-ci.org/mozilla-b2g/gaia/builds/22105389.
Attachment #8400554 - Flags: review?(mmedeiros)
Comment on attachment 8400554 [details] [review]
Pull request

Hi Miller,

Could you help me to review the patch?
The test is already passed for 30 times continually on Travis,
see it in https://travis-ci.org/mozilla-b2g/gaia/builds/22105389.

Thanks.
Attachment #8400554 - Flags: review?(mmedeiros)
Hi Miller,

I already updated the patch
Please help me to review it.

And the test is also passed for 30 times on Travis,
and see it at https://travis-ci.org/mozilla-b2g/gaia/builds/22174174.

Thanks.
Comment on attachment 8400554 [details] [review]
Pull request

looking good! thanks!
Attachment #8400554 - Flags: review?(mmedeiros) → review+
Hi Miller,

Thanks for the review.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.