987389 - [Clock] Make timer dialog spin buttons accessible

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Eitan Isaacson [:eeejay]]

Do something similar to the time selector in the system app.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17549

Comment 2

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8395991 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17549

Woohoo. I tested it locally and it still seems to work, but I don't know how to work the screen reader, so I'm assuming that that part works as you intended. r=mcav! Thanks!

Comment 3

[Eitan Isaacson [:eeejay]]

(In reply to Marcus Cavanaugh [:mcav] <[e-mail]> from comment #2)
> Comment on attachment 8395991 [details] [review]
> Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17549
> 
> Woohoo. I tested it locally and it still seems to work, but I don't know how
> to work the screen reader, so I'm assuming that that part works as you
> intended. r=mcav! Thanks!

Thanks! I highly encourage you to give the screen reader a spin and see for yourself.

Comment 4

[Eitan Isaacson [:eeejay]]

https://github.com/mozilla-b2g/gaia/commit/c95d26835cb4fd00fd782f71e619f73445e71394

Comment 5

[Kevin Grandon :kgrandon]

Reverted due to unit test failures: https://github.com/mozilla-b2g/gaia/commit/b08b7f8e24867a58f7ce55e23c19498d411ef165

Please ensure travis is green before merging any pull request. Thanks!

 1) [clock] Spinner values: [0, 1, 2] "before each" hook:

TypeError: this.textValues is undefined

at Spinner (http://clock.gaiamobile.org:8080/js/picker/spinner.js?cache_bust=1395771528618:113:5)

at (anonymous) (http://clock.gaiamobile.org:8080/test/unit/picker/spinner_test.js:100:1)

at wrapper (http://clock.gaiamobile.org:8080/common/test/mocha_generators.js:62:13)

at run (http://clock.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709:7)

at next (http://clock.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3973:5)

at (anonymous) (http://clock.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984:5)

at (anonymous) (http://clock.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932:28)

Comment 6

[Eitan Isaacson [:eeejay]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17601

Fixed patch to pass unit test. Lets see if travis is happy..

Comment 7

[Eitan Isaacson [:eeejay]]

Comment on attachment 8396665 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17601

Travis is reporting a failure in an unrelated unit test from another app.

Comment 8

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8396665 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17601

Okay, after a couple reloads, Travis passes -- looks OK to me.

Comment 9

[Eitan Isaacson [:eeejay]]

https://github.com/mozilla-b2g/gaia/commit/aa36a654475a680507217fe274f3c91de6202d1b

Comment 10

[Francesco Lodolo [:flod]]

Is there a specific reason for this inconsistency: one second, one minute, 1 hour?