987541 - [B2G] [RIL] consider moving Supplementary Service WebAPI from mozMobileConnections to mozTelephony

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: RIL, defect)

Description

[Hsin-Yi Tsai (she/her) [:hsinyi]]

In bug 889737, we are going to unify mozMobileConnection.sendMMI() and mozTelephony.dial().

After that, user can access SS via two WebAPI -- thru MMI with telephony.dial() or thru SS WebAPI, such as mozMobileConnection.setCallWaitingOption().

Considering the API permission and considering the API scope, IMHO we should think about moving SS APIs to mozTelehony, and keep mozMobileConnections focus on radio state, network registration, etc.

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

More specifically, below are the APIs that I think should be moved to mozTelephony.

- setCallForwardingOption
- getCallForwardingOption
- setCallWaitingOption
- getCallWaitingOption
- setCallBarringOption
- getCallBarringOption
- changeCallBarringPassword
- setCallingLineIdRestriction
- getCallingLineIdRestriction

Comment 2

[Ken Chang[:kenkai]]

Put this bug into backlog.

Comment 3

[Edgar Chen [:edgar]]

(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #1)
> More specifically, below are the APIs that I think should be moved to
> mozTelephony.
> 
> - setCallForwardingOption
> - getCallForwardingOption
> - setCallWaitingOption
> - getCallWaitingOption
> - setCallBarringOption
> - getCallBarringOption

It's a good time to address below comments in this bug, i.e. s/*Option/*Options

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=818393#c44
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=907018#c19

> - changeCallBarringPassword
> - setCallingLineIdRestriction
> - getCallingLineIdRestriction

Comment 4

[Szu-Yu Chen [:aknow] (inactive)]

(In reply to Edgar Chen [:edgar][:echen] from comment #3)
> (In reply to Hsin-Yi Tsai  [:hsinyi] from comment #1)
> > More specifically, below are the APIs that I think should be moved to
> > mozTelephony.
> > 
> > - setCallForwardingOption
> > - getCallForwardingOption
> > - setCallWaitingOption
> > - getCallWaitingOption
> > - setCallBarringOption
> > - getCallBarringOption
> 
> It's a good time to address below comments in this bug, i.e.
> s/*Option/*Options
> 
> [1] https://bugzilla.mozilla.org/show_bug.cgi?id=818393#c44
> [2] https://bugzilla.mozilla.org/show_bug.cgi?id=907018#c19
> 
> > - changeCallBarringPassword
> > - setCallingLineIdRestriction
> > - getCallingLineIdRestriction

How about just drop 'options'?
- setCallForwarding(in options)
- getCallForwarding
- setCallWaiting
- getCallWaiting
- setCallBarring
- getCallBarring

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Szu-Yu Chen [:aknow] from comment #4)
> (In reply to Edgar Chen [:edgar][:echen] from comment #3)
> > (In reply to Hsin-Yi Tsai  [:hsinyi] from comment #1)
> > > More specifically, below are the APIs that I think should be moved to
> > > mozTelephony.
> > > 
> > > - setCallForwardingOption
> > > - getCallForwardingOption
> > > - setCallWaitingOption
> > > - getCallWaitingOption
> > > - setCallBarringOption
> > > - getCallBarringOption
> > 
> > It's a good time to address below comments in this bug, i.e.
> > s/*Option/*Options
> > 
> > [1] https://bugzilla.mozilla.org/show_bug.cgi?id=818393#c44
> > [2] https://bugzilla.mozilla.org/show_bug.cgi?id=907018#c19
> > 
> > > - changeCallBarringPassword
> > > - setCallingLineIdRestriction
> > > - getCallingLineIdRestriction
> 
> How about just drop 'options'?
> - setCallForwarding(in options)
> - getCallForwarding
> - setCallWaiting
> - getCallWaiting
> - setCallBarring
> - getCallBarring

Neat names! sounds good :)

Comment 6

[Szu-Yu Chen [:aknow] (inactive)]

In order to land the patch smoothly without breaking the functionality, the patches should be land in 3 phases:
1. provide the new APIs in mozTelephony
2. migrate gaia from mozMobileConnections to mozTelephony
3. phase out old APIs in mozMobileConnections

I'll suggest we do the first item in this bug and file bugs for 2 and 3.

Comment 7

[a2882525224]

Hi,

Thanks for suggestions and I'll do the phase 1 first.

Comment 8

[BMO Automation]

Firefox OS is not being worked on